Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Hide Accounts With Zero Balance in Asset Details #17395

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Will now hide accounts with a zero balance on the Asset Details screen.

Resolves brave/brave-browser#28761

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Add a token that you have a balance of to your portfolio
  2. Create a bunch of accounts for that coin type
  3. Select your token on the Portfolio view
  4. You should only see accounts that hold a balance for that token.

Before:

Before

After:

After

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 27, 2023 15:35
@Douglashdaniel Douglashdaniel self-assigned this Feb 27, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 27, 2023
@Douglashdaniel Douglashdaniel force-pushed the hide-accounts-with-zero-balance branch from 48d11a9 to a4df74b Compare February 27, 2023 15:57
@Douglashdaniel Douglashdaniel requested a review from onyb February 27, 2023 15:58
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 31d1b73 into master Feb 27, 2023
@Douglashdaniel Douglashdaniel deleted the hide-accounts-with-zero-balance branch February 27, 2023 19:57
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide accounts that don't hold an asset balance (asset detail view)
4 participants