Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet address shows up as Contract address when set to Ethereum Mainnet #28886

Open
srirambv opened this issue Mar 3, 2023 · 1 comment
Open
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-investigation A bug not 100% confirmed/fixed OS/Desktop QA/Yes

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 3, 2023

Description

Wallet address shows up as Contract address when set to Ethereum Mainnet

Steps to Reproduce

  1. Setup eth-manual-test on localhost
  2. Set network to Ethereum Mainnet
  3. Create a second Ethereum Account
  4. Copy the main account address
  5. Paste the main account address in the text field next to eth_signTransaction and click on it
  6. Panel loads and shows account address as Contract address that's clickable but doesn't do anything

Actual result:

Contract.Address.instead.of.Wallet.Address.mp4

Expected result:

Should show address as is unless its a contract address

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 11 Version 22H2 (Build 22621.1265)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No but will be when 1.49 lands
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Related to #27188
cc: @Douglashdaniel @nvonpentz

@srirambv srirambv added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Mar 3, 2023
@srirambv srirambv added this to Web3 Mar 3, 2023
@Douglashdaniel Douglashdaniel self-assigned this Mar 10, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Mar 10, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 10, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to Backlog in Web3 Mar 13, 2023
@Douglashdaniel Douglashdaniel added the needs-investigation A bug not 100% confirmed/fixed label Mar 13, 2023
@srirambv
Copy link
Contributor Author

This happens to Filecoin transactions as well

FIL.Contract.Address.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-investigation A bug not 100% confirmed/fixed OS/Desktop QA/Yes
Projects
Status: Backlog
Development

No branches or pull requests

2 participants