Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localisation for gas titles #26136

Closed
Pavneet-Sing opened this issue Oct 19, 2022 · 1 comment · Fixed by brave/brave-core#16888
Closed

Add localisation for gas titles #26136

Pavneet-Sing opened this issue Oct 19, 2022 · 1 comment · Fixed by brave/brave-core#16888
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@Pavneet-Sing
Copy link

Description

Add localisation for gas titles

Expected result:

Fetch titles via getLocale
@Pavneet-Sing Pavneet-Sing added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Oct 19, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Oct 21, 2022
@muliswilliam muliswilliam self-assigned this Jan 27, 2023
@muliswilliam muliswilliam moved this from Backlog to In Review in Web3 Jan 27, 2023
@muliswilliam muliswilliam mentioned this issue Jan 27, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 24, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 24, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from brave/brave-core#16888
  • Verified on transaction confirmation screen, transaction info labels are shown same as before.
  • Encountered #28886
    image

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#16888
  • Verified on transaction confirmation screen, transaction info labels are shown same as before.
  • Encountered #28886
    gQfCMJrA1N

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16888
  • Verified on transaction confirmation screen, transaction info labels are shown same as before.
  • Encountered #28886
    image

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Add localization for file transaction info brave/brave-core
4 participants
@Pavneet-Sing @srirambv @brave-builds @muliswilliam