Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onboarding for hardware wallets #29107

Closed
muliswilliam opened this issue Mar 16, 2023 · 1 comment · Fixed by brave/brave-core#17637
Closed

Add onboarding for hardware wallets #29107

muliswilliam opened this issue Mar 16, 2023 · 1 comment · Fixed by brave/brave-core#17637
Assignees
@muliswilliam
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@muliswilliam
Copy link

No description provided.

@muliswilliam muliswilliam self-assigned this Mar 16, 2023
@muliswilliam muliswilliam converted this from a draft issue Mar 16, 2023
@muliswilliam muliswilliam moved this from Backlog to In Review in Web3 Mar 16, 2023
@muliswilliam muliswilliam mentioned this issue Mar 16, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Mar 29, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Mar 29, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS Linux
  • Verified steps from brave/brave-core#17637
  • Verified selecting hardware wallet during onboarding brings up connect hardware wallet route after agreeing to terms.
  • Verified able to select EVM/Solana/Filecoin hardware wallet accounts directly during onboarding
21907.mp4

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS Windows 11 Version 22H2 (Build 22621.1702)

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (arm64)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17637
  • Verified selecting hardware wallet during onboarding brings up connect hardware wallet route after agreeing to terms.
  • Verified able to select EVM/Solana/Filecoin hardware wallet accounts directly during onboarding
29107.mov

@LaurenWags LaurenWags mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add onboarding for hardware wallets brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam