Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): Add onboarding for hardware wallets #17637

Merged
merged 4 commits into from
Mar 29, 2023
Merged

feat(wallet): Add onboarding for hardware wallets #17637

merged 4 commits into from
Mar 29, 2023

Conversation

muliswilliam
Copy link
Contributor

Resolves brave/brave-browser#29107

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.2023-03-16.at.11.27.34.mov

@muliswilliam muliswilliam requested review from a team as code owners March 16, 2023 08:51
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Mar 16, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam force-pushed the feat-hardware-onboarding branch from de4ac64 to 780756a Compare March 28, 2023 10:41
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

josheleonard
josheleonard approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

cypt4
cypt4 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@cypt4 cypt4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core lgtm

Douglashdaniel
Douglashdaniel approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@muliswilliam muliswilliam merged commit 96769bc into master Mar 29, 2023
@muliswilliam muliswilliam deleted the feat-hardware-onboarding branch March 29, 2023 13:20
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Mar 29, 2023
@srirambv srirambv mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josheleonard josheleonard josheleonard approved these changes

@Douglashdaniel Douglashdaniel Douglashdaniel approved these changes

@cypt4 cypt4 cypt4 approved these changes

Assignees

@muliswilliam muliswilliam

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging this pull request may close these issues.

Add onboarding for hardware wallets
5 participants
@muliswilliam @brave-builds @josheleonard @Douglashdaniel @cypt4