Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Tip" language to "Contribution" language and remove "One-time" language #29603

Closed
2 tasks
Miyayes opened this issue Apr 10, 2023 · 2 comments · Fixed by brave/brave-core#18027
Closed
2 tasks

Change "Tip" language to "Contribution" language and remove "One-time" language #29603

Miyayes opened this issue Apr 10, 2023 · 2 comments · Fixed by brave/brave-core#18027
Assignees
@emerick
Labels
feature/rewards OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.52.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 10, 2023 •
edited
Loading

Description

  • Replace "Tip" language with "Contribution" language
  • Gracefully remove "One-time" language (careful if it introduces ambiguity)

General rules:

  1. Replace "Tip" with "Contribution" where it makes sense (note pluralization)
  2. Monthly Tips --> Monthly Contributions
  3. Tipped --> Contributed
  4. Send Tip --> Send Contribution

Do not change "Tip" on inline tip buttons, and text specifically related to inline Tip buttons.
@Miyayes
Copy link
Collaborator Author

Miyayes commented Apr 10, 2023

Target: 1.52.x alongside the Tip Banner 3.0.

@Miyayes Miyayes added the QA/Yes label Apr 11, 2023
@emerick emerick mentioned this issue Apr 12, 2023
Merged
25 tasks
@emerick emerick added this to the 1.52.x - Nightly milestone Apr 20, 2023
@Miyayes Miyayes mentioned this issue Apr 28, 2023
Closed
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 22, 2023
@LaurenWags
Copy link
Member

LaurenWags commented May 22, 2023 •
edited
Loading

Verified with

Brave | 1.52.108 Chromium: 114.0.5735.26 (Official Build) beta (x86_64)
-- | --
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS | macOS Version 13.3.1 (a) (Build 22E772610a)

Additional contribution/banner testing can be found under #28148.

Verified UI as per brave/brave-core#18027 (comment).

brave://rewards brave://rewards Panel Panel Contribution banner Monthly Statement
1 2 3 4 5 6

Per #29603 (comment), confirmed "Tip" wording remains in place for in-line tip buttons and text related to in-line tip buttons.

brave://settings/rewards (Rewards disabled) brave://settings/rewards (Rewards enabled) brave://rewards Twitter GitHub Reddit
1 2 3 4 5 6

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Change Tip verbiage to Contribution brave/brave-core
3 participants
@emerick @Miyayes @LaurenWags