Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPFS settings doesn't match feature state #29647

Closed
cypt4 opened this issue Apr 12, 2023 · 4 comments · Fixed by brave/brave-core#18042
Closed

IPFS settings doesn't match feature state #29647

cypt4 opened this issue Apr 12, 2023 · 4 comments · Fixed by brave/brave-core#18042
Assignees
@cypt4
Labels
bug feature/settings feature/web3/ipfs OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.51.x - Release #3

Comments

@cypt4
Copy link

cypt4 commented Apr 12, 2023 •
edited
Loading

IPFS setting switches off after re-enter settings page.

Steps to reproduce

  1. Open settings
  2. Turn on using IPFS setting
  3. Re-enter settings(relaunch app)

Actual result

The setting is off

Expected result

The setting is on

  • Can you reproduce this issue with the current Play Store version? +
  • Can you reproduce this issue with the current Play Store Beta version? +
  • Can you reproduce this issue with the current Play Store Nightly version? +

Device details

  • Install type (ARM, x86): Arm
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 11

Brave version

1.50
@cypt4 cypt4 mentioned this issue Apr 13, 2023
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Apr 13, 2023
@cypt4
Fix IPFS gateway Android setting
8a6ca48 
Resolves brave/brave-browser#29647
@yrliou yrliou added this to Web3 Apr 13, 2023
@yrliou yrliou moved this to In Progress in Web3 Apr 13, 2023
@yrliou yrliou moved this from In Progress to In Review in Web3 Apr 13, 2023
cypt4 added a commit to brave/brave-core that referenced this issue Apr 14, 2023
@cypt4
Fix IPFS gateway Android setting
93e21da 
Resolves brave/brave-browser#29647
cypt4 added a commit to brave/brave-core that referenced this issue Apr 19, 2023
@cypt4
Fix IPFS gateway Android setting
4d46cba 
Resolves brave/brave-browser#29647
cypt4 added a commit to brave/brave-core that referenced this issue Apr 20, 2023
@cypt4
Fix IPFS gateway Android setting (#18042)
5be6f7e 
Resolves brave/brave-browser#29647
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Apr 20, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 20, 2023
@kjozwiak kjozwiak mentioned this issue May 10, 2023
Closed
@hffvld
Copy link
Contributor

hffvld commented May 10, 2023

Verified on Google Pixel 7 and Galaxy Tab S8 using version(s):

Device/OS: 
- Google Pixel 7 [panther_beta-user 14 UPB1.230309.017 release-keys]
- SM-X700 Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.52.92 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)

STEPS:

  1. Launch Brave > Hamburger Menu > Settings
  2. Brave Shields & privacy
  3. Find IPFS Gateway and enable it
  4. Go back to a previous screen or close and reopen the settings

ACTUAL RESULTS:

  • Verified that the IPFS toggle switch is set to ON by default
  • Verified that going back and forth, closing and reopening Brave doesn't affect the current state of the IPFS toggle switch
timestamp_12-13-24_12-14-32.mp4

deeppandya pushed a commit to brave/brave-core that referenced this issue May 11, 2023
@cypt4 @deeppandya
Fix IPFS gateway Android setting (#18042)
e081f73 
Resolves brave/brave-browser#29647
@deeppandya deeppandya mentioned this issue May 11, 2023
Merged
7 tasks
kjozwiak pushed a commit to brave/brave-core that referenced this issue May 15, 2023
@deeppandya @cypt4
Fix IPFS gateway Android setting (#18042) (Uplift to 1.51.x) (#18450)
dbe5115 
Fix IPFS gateway Android setting (#18042)

Resolves brave/brave-browser#29647

Co-authored-by: cypt4 <[email protected]>
@kjozwiak
Copy link
Member

Used #29647 (comment) as the verification for the uplift into 1.51.x. Removing the QA Pass labels as this will need to be re-checked using 1.51.x once we get the RC builds.

@kjozwiak
Copy link
Member

The above requires 1.51.117 or higher for 1.51.x verification 👍

@stephendonner stephendonner changed the title IPFS settings doens't match feature state IPFS settings doesn't match feature state May 16, 2023
@hffvld
Copy link
Contributor

hffvld commented May 16, 2023

Verified on Google Pixel 7using version(s):

Device/OS: Google Pixel 7 [panther_beta-user 13 UPB2.230407.014 release-keys]
Brave build: 1.51.117 
Chromium: 113.0.5672.92 (Official Build) (64-bit)

STEPS:

  1. Launch Brave > Hamburger Menu > Settings
  2. Brave Shields & privacy
  3. Find IPFS Gateway and enable it
  4. Go back to a previous screen or close and reopen the settings

ACTUAL RESULTS:

  • Verified that the IPFS toggle switch is set to ON by default
  • Verified that going back and forth, closing and reopening Brave doesn't affect the current state of the IPFS toggle switch
IPFS_toggle_FIXED.mp4

@kjozwiak kjozwiak mentioned this issue May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
bug feature/settings feature/web3/ipfs OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release #3
Development

Successfully merging a pull request may close this issue.

Fix IPFS gateway Android setting brave/brave-core
4 participants
@kjozwiak @brave-builds @cypt4 @hffvld