Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 115 to Chromium 116. #30747

Closed
mkarolin opened this issue Jun 1, 2023 · 7 comments · Fixed by brave/brave-core#18808
Closed

Upgrade from Chromium 115 to Chromium 116. #30747

mkarolin opened this issue Jun 1, 2023 · 7 comments · Fixed by brave/brave-core#18808
Assignees
@samartnik @cdesouza-chromium @mkarolin
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass - Android ARM QA Pass - Android Tab QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Milestone
1.57.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jun 1, 2023 •
edited
Loading

Upgrade from Chromium 115 to Chromium 116

https://chromium.googlesource.com/chromium/src/+log/115.0.5790.98..116.0.5845.42/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Changing shield settings works correctly
  • All items a present and work as expected in the ☰ menu
  • Translate page works
  • Signing into Google sites works
  • Brave Side Panel looks/works correctly
  • Clear browsing data for time span works
  • Omnibox suggestions are shown when enabled

MacOS:
Installation and upgrade work (upgrade 1.56.x -> 1.57.x and 1.57.x to 1.57.x)

Linux:

  • Check that passwords are accessible and encrypted when upgrading to this version on a system that has libgnome-keyring installed
  • Check that new install of this version uses encryption when saving passwords.

iOS Affected areas:
N/A

Android Affected areas:

  • Bottom toolbar (double check it properly works with tab list, like when you open link in a new tab in group)
  • Import/export bookmarks (check that it works)
  • Downloads (check that different files are downloaded properly)
  • Sync (double check it generally works)
  • Top toolbar (check that there is no excessive items in phones and tablets)
@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop labels Jun 1, 2023
@mkarolin mkarolin mentioned this issue Jul 18, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 27, 2023
@mkarolin mkarolin mentioned this issue Jul 27, 2023
Merged
25 tasks
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 27, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.58.51 Chromium: 116.0.5845.51 (Official Build) nightly (64-bit)
-- | --
Revision | 7a80e038ad7ca3ba162d251def937ef9a0d96d4c
OS | Windows 10 Version 22H2 (Build 19045.3208)
Changing shield settings works correctly_PASSED
Clean profile

Restart browser and verify updated shield settings retained

Case 1: Browser restart retain the updated site specific shield settings_PASSED

Trackers & ads blocking

Case 1:

  1. Clean profile 1.58.51 - CR 116
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block trackers and ads to Aggressive
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are reatined

Case 2:

  1. Clean profile 1.58.51 - CR 116
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Aggressive to Block trackers and ads
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are reatined

Case 3:

  1. Clean profile 1.58.51 - CR 116
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block trackers and ads to Allow all trackers and ads
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are reatined

Block fingerprinting

Case 1:

  1. Clean profile 1.58.51 - CR 116
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block fingerprinting to Aggressive
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are reatined

Case 2:

  1. Clean profile 1.58.51 - CR 116
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Aggressive to Block fingerprinting
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are reatined

Case 3:

  1. Clean profile 1.58.51 - CR 116
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block fingerprinting to Allow fingerprinting
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are reatined

Block cookies

Case 1:

  1. Clean profile 1.58.51 - CR 116
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block cross site cookies to Block all cookies
  5. Restart the browser
  6. Open the site shield settings, updated cookies settings are reatined

Case 2:

  1. Clean profile 1.58.51 - CR 116
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block all cookies to Allow all cookies
  5. Restart the browser
  6. Open the site shield settings, updated cookies settings are reatined

Case 3:

  1. Clean profile 1.58.51 - CR 116
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Allow all cookies to Block cross site cookies
  5. Restart the browser
  6. Open the site shield settings, updated cookies settings are reatined
Case 2: Browser restart retain the updated global shield settings_PASSED

Trackers & ads blocking

Case 1:

  1. Clean profile 1.58.51 - CR 116
  2. Navigate to brave://settings/shields
  3. Change the trackers and ad blocking default settings from Standard to Aggressive
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are reatined

Case 2:

  1. Clean profile 1.58.51 - CR 116
  2. Navigate to brave://settings/shields
  3. Change the trackers and ad blocking default settings from Aggressive to Disabled
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are reatined

Case 3:

  1. Clean profile 1.58.51 - CR 116
  2. Navigate to brave://settings/shields
  3. Change the trackers and ad blocking default settings from Disabled to Standard
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are reatined

Fingerprint blocking

Case 1:

  1. Clean profile 1.58.51 - CR 116
  2. Navigate to brave://settings/shields
  3. Change the fingerprinting default settings from Standard to Strict, may break sites
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are reatined

Case 2:

  1. Clean profile 1.58.51 - CR 116
  2. Navigate to brave://settings/shields
  3. Change the fingerprinting default settings from Strict, may break sites to Disabled
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are reatined

Case 3:

  1. Clean profile 1.58.51 - CR 116
  2. Navigate to brave://settings/shields
  3. Change the fingerprinting default settings from Disabled to Standard
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are reatined

Cookies blocking

Case 1:

  1. Clean profile 1.58.51 - CR 116
  2. Navigate to brave://settings/shields
  3. Change the cookies default settings from Only cross site to All
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are reatined

Case 2:

  1. Clean profile 1.58.51 - CR 116
  2. Navigate to brave://settings/shields
  3. Change the cookies default settings from All to Disabled
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are reatined

Case 3:

  1. Clean profile 1.58.51 - CR 116
  2. Navigate to brave://settings/shields
  3. Change the cookies default settings from Disabled to Only cross sites
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are reatined

Site shield settings in Private window

Case 1: Per site shiled settings are propagated to private windows_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open a site cnn.com in the normal window
  • Change the local site shield settings for the site cnn.com
    1. Block the scripts 2. Aggressively block trackers and ads 3. Block fingerprinting 4. Block cross-site cookies
  • Open the private window and open cnn.com
  • Confirmed the CNN site shield settings are retained in the Private tab
Normal window Private window
image image
Case 2: Updated global shiled settings are propagated to Private windows_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open a site cnn.com in the normal window
  • Change the global shield settings
  • Open a site A and confirmed global shield settings are retained in the normal window
  • Open the private window and open a site A
  • Confirmed that the global shield settings are retained in the Private tab
Case 3: Verify that updated per site shield settings in Private window are NOT propagated to Normal window_PASSED
  • Make changes to shield settings in the Private tab (e.g Allow ads and trackers)
  • Go to the normal window and open CNN.com and confirm shield settings changes are NOT retained in the normal window

Verify disable per site shield settings propagated to all the tabs

Case 1: Disable local shield settings for a site A_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open any website A in tab 1
  • Disable the default site shield settings for Adblock, Fingerprint, and block cookies (allow all the settings)
  • Make sure disabled site settings are retained for the site A in tab 1
  • Open site A in tab2
  • Confirmed that updated site shield settings are retained in tab 2 for the site A
Case 2: Disable global shield settings for a site A_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open global shield settings and disable the default global shield settings (allow all the settings)
  • Open any website A in tab 1
  • Make sure disabled global shield settings are retained for the site A in tab 1
  • Open site A in tab 2
  • Confirmed that disabled global shield settings are retained in tab 2 for the site A
Case 3: Turn OFF the per site shield switch_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open any website A in tab 1
  • Disable the shield switch
  • Make sure disabled settings are retained for the site A in tab 1
  • Open site A in tab2
  • Confirmed that disabled site shield settings are retained in tab 2 for the site A

Verify disable per site shield settings propagated to all the windows

Case 1: Disable local shield settings for a site A in window 1_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open any website A in win 1
  • Disable the default site shield settings for Adblock, Fingerprint, and block cookies (allow all the settings)
  • Make sure updated site shield settings are retained for the site A in win 1
  • Open site A in win 2
  • Confirmed that disabled site shield settings are retained in win 2 for the site A
Case 2: Disable global shield settings for a site A_ in windows 1_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open global shield settings and disable the default global shield settings (allow all the settings)
  • Open any website A in win 1
  • Make sure disabled global shield settings are retained for the site A in win 1
  • Open site A in win 2
  • Confirmed that disabled global shield settings are retained in win 2 for the site A
Case 3: Turn OFF the per site shield switch_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open any website A in win 1
  • Disable the shield switch
  • Make sure disabled settings are retained for the site A in win 1
  • Open site A in win 2
  • Confirmed that disabled site shield settings are retained in win 2 for the site A

Verify change per site shield settings propagated to all the tabs

Case 1: Change local shield settings for a site A_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open any website A in tab 1
  • Change the default site shield settings for Adblock, Fingerprint, and block cookies
  • Make sure changed site settings are retained for the site A in tab 1
  • Open site A in tab2
  • Confirmed that updated site shield settings are retained in tab 2 for the site A
Case 2: Changed global shield settings for a site A_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open global shield settings and disable the default global shield settings
  • Open any website A in tab 1
  • Make sure changed global shield settings are retained for the site A in tab 1
  • Open site A in tab 2
  • Confirmed that changed global shield settings are retained in tab 2 for the site A

Verify change per site shield settings propagated to all the windows

Case 1: Change local shield settings for a site A_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open any website A in win 1
  • Change the default local shield settings for Adblock, Fingerprint, and block cookies
  • Make sure per site shield settings are retained for the site A in win 1
  • Open site A in win 2
  • Confirmed that per site shield settings are retained in win 2 for the site A
Case 2: Changed global shield settings for a site A_PASSED
  • Clean profile 1.58.51 - CR 116
  • Open any website A in win 1
  • Change the default global shield settings for Adblock, Fingerprint, and block cookies
  • Make sure changed global shield settings are retained for the site A in win 1
  • Open site A in win 2
  • Confirmed that changed global shield settings are retained in win 2 for the site A
Upgrade profile
Case 1: Install 1.56.x CR 115 and upgrade it to 1.58.x CR 116 - PASSED

Case 1.1: Default shield settings upgrade - PASSED

 1. Clean profile 1.56.x
 8. Open a few websites 
 9. Open brave://settings/help
 10. Upgrade the profile to  1.58.x CR 116
 11. Confirmed profile is upgraded to  1.58.x CR 116
 12. Confirmed default shield settings are retained

Case 1.2: Update the default shield settings and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Edit the site-specific shield settings
 5. Open brave://settings/help
 6. Upgrade the profile to  1.58.x CR 116
 8. Confirmed profile is upgraded to  1.58.x CR 116
 13. Confirmed that updated shield settings are retained after the upgrade

Case 1.3: Update the global default shield settings and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Edit the global shield settings via brave://settings/shields
 4. Open brave://settings/help
 5. Upgrade the profile to 1.58.x CR 116
 6. Confirmed profile is upgraded to 1.58.x CR 116
 9. Confirmed that updated global shield settings are retained after the upgrade

Case 1.4: Turn OFF the shield for a few sites and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Turn OFF the shield for a few sites via panel
 4. Open brave://settings/help
 5. Upgrade the profile to 1.58.x CR 116
 6. Confirmed profile is upgraded to 1.58.x CR 116
 8. Confirmed that shield settings are retained after the upgrade

Case 1.5: Block scripts and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Block scripts for any of the sites via Panel or via brave://settings/shields
 4. Open brave://settings/help
 5. Upgrade the profile to 1.58.x CR 116
 6. Confirmed profile is upgraded to 1.58.x CR 116
 8. Confirmed that scrpit block settings are retained after the upgrade

Case 1.6: Block HTTPS upgrade and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Block HTTPS upgrade via Panel or via brave://settings/shields
 4. Open brave://settings/help
 5. Upgrade the profile to 1.58.x CR 116
 6. Confirmed profile is upgraded to 1.58.x CR 116
 8. Confirmed that block HTTPS upgrade settings are retained after the upgrade
All items a present and work as expected in the ☰ menu_PASSED
  • Confirmed that all the menu items are present in the Hamburger menu
  • Confirmed tha click on each settings navigates to intended page
    image
Signing into Google sites works_PASSED
  1. Clean profile 1.58.51 - CR116
  2. Restart the browser and ensure that BraveGoogleSignInPermissionStudy:Enabled via brave://version
  3. Ensure that Google sign-in is visible via brave://settings/content
  4. Ensure that Sites can ask to use legacy Google Sign-In via third-party cookies is enabled by default when added into BraveGoogleSignInPermissionStudy:Enabled
  5. Visit https://www.expensify.com and click on the Google login button
  6. Ensure that you receive the Allow use of third-party cookies for legacy Google sign-in modal without any issues
  7. Click on Allow and ensure it appears under Allowed to use third-party cookies for legacy Google Sign-In via brave://settings/content/googleSignIn
  8. Remove Expensify from Allowed to use third-party cookies for legacy Google Sign-In via brave://settings/content/googleSignIn
  9. Visit https://www.expensify.com and click on the Google login button (should get the modal once again)
  10. Click on Block and ensure it appears under Not allowed to use third-party cookies for legacy Google Sign-In via brave://settings/content/googleSignIn
  11. Remove Expensify from Not allowed to use third-party cookies for legacy Google Sign-In via brave://settings/content/googleSignIn
  12. Disable Google sign-in via Don't allow legacy Google Sign-In via third-party cookies under brave://settings/content/googleSignIn
  13. Visit https://www.expensify.com and click on the Google login button
  14. Ensure that a modal isn't being displayed/appearing
step 3 step 4 step 6 step 7 step 8 step 9 step 10 step 11 step 12 step 14
image image image image image image image image image image
Brave Side Panel looks/works correctly_PASSED
  • Confirmed that sidebar is shown by default in the nightly channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
  • Confirmed that tooltip is shown correctly for each menu item in sidebar
  • Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and REading list works as expected
Clear browsing data for time span works_PASSED
Basic_Last hour_PASSED

Case 1:

  1. Clean profile 1.58.51 CR 116
  2. Create a browser hostory and search history
  3. Logged into any website
  4. Open brave://settings/clearBrowserData
  5. Confirm that Browsing history, Cookies and other site data and Cached images and files checkboxes are selected by default
  6. Click on Clear data for Basic, Last hour
  7. Confirmed that browser hostory and search history are deleted
  8. Confirmed that users are logged out fron the logged in sites

Before:

Example Example
image image

After:

Example Example
image image

Case 2:

  1. Clean profile 1.58.51 CR 116
  2. Create a browser hostory and search history
  3. Logged into any website
  4. Open brave://settings/clearBrowserData
  5. Confirm that Browsing history, Cookies and other site data and Cached images and files checkboxes are selected by default
  6. Uncheck the Cookies and other site data
  7. Click on Clear data for Basic, Last hour
  8. Confirmed that browser hostory and search history are deleted
  9. Confirmed that users are STILL logged into the logged in sites
Advanced_All time_PASSED

Case 1: All time

  1. Clean profile 1.58.51 CR 116
  2. Import browser history, passwods, bookmarks and extensions from your daily driver or chrome
  3. Open brave://settings/clearBrowserData
  4. Click on the Adnavce tab and select All time range from the dropdown
  5. Select all the checkboxes and click on Clear data
  6. Confirm that all the imported data is removed from the browser
  7. Open brave://history, brave://downloads and password and autofill data and confirm that there is no data remained
Example Example Example Example
image image image image
Advanced_Last 7 days_PASSED
  1. Clean profile 1.58.51 CR 116
  2. Import browser history, passwods, bookmarks and extensions from your daily driver or chrome
  3. Open brave://settings/clearBrowserData
  4. Click on the Adnavce tab and select Last 7 days range from the dropdown
  5. Select all the checkboxes and click on Clear data
  6. Confirm that last 7 days data is been removed from the browser and remaing days browser history and data is still retained
  7. In my case data is been deleted from 22 july to 28 july, 21st browser history and data still retained
Example Example
image image
Advanced_Last 4 weeks_PASSED
  1. Clean profile 1.58.51 CR 116
  2. Import browser history, passwods, bookmarks and extensions from your daily driver or chrome
  3. Open brave://settings/clearBrowserData
  4. Click on the Adnavce tab and select Last 4 weeks range from the dropdown
  5. Select all the checkboxes and click on Clear data
  6. Confirm that last 4 weeks data is been removed from the browser and remaing days browser history and data is still retained
  7. In my case last 4 weeks date is been deleted and June 30th browser history and data still retained
Example Example
image image
On exit_PASSED
  • Visit few sites and create history and create download data history and create address and autofill date
  • Save the password for few websites and change the site shield settings
  • Select the checkboxes for history, download and autofill date in On exit clear browsing date modal
  • Exit the browser and Relaunch the browser
  • Confirmed that the data is cleared for the selected items history, download and autofill
  • Confirmed that site shields settings and password data is retained in the browser

Before:

Example Example Example Example Example
image image image image image

After:

Example Example Example Example Example
image image image image image
Omnibox suggestions are shown when enabled_PASSED
  1. Confirm that the Show autocomplete suggestions in address bar switch is enabled by default under brave://settings/appearance
  2. Open a new tab and enter the string Buzz in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list
  3. Go to brave://settings/appearance and uncheck/disable the checkbox Top sites
  4. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled
  5. Open the buzzfeed.com in any tab
  6. Keep the Top sites still disabled/unchecked
  7. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the Browsing History list
  8. Go to brave://settings/appearance and uncheck/disable the checkbox Browsing History and keep Top sites as it is in step 6
  9. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites and browsing history toggles are disabled/unchecked
  10. Bookmark the site buzzfeed.com which is already opened in step 5 and close the tab
  11. Keep the brave://settings/appearance setting as it is
  12. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the Bookmarks list
  13. Go to brave://settings/appearance and uncheck Bookmarks (all the 3 settings checkboxes are unchecked in this step)
  14. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites , browsing history and bookmarks toggles are disabled/unchecked
  15. Enable alll the 3 switches under Show autocomplete suggestions in address bar main switch
  16. Disable the main switch Show autocomplete suggestions in address bar
  17. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as Show autocomplete suggestions in address bar main switch is OFF
step 2 step 3 step 4 step 7 step 8 step 9 step 10 step 11 step 12 step 13 step 14 step 15 step 16 step 17
image image image image image image image image image image image image image
-----

Settings comparison

Components updater

  • A new components is added as part of Brave
    image

  • Components are updates successfully without any error

1.56.14 Chromium: 115.0.5790.114 1.58.52 Chromium: 116.0.5845.51
image image

Translate page works - PASSED

  • Installed 1.58.55
  • Launch Brave
  • visited https://www.publico.pt/
  • confirmed Brave translate functionality worked as expected (Portuguese to English)
  • confirmed when selected choose another - Hindi, page translated as expected
  • confirmed when selected Never translate Portuguese, Brave translate icon is no longer shown
  • confirmed when selected Never translate this site, Brave translate icon is no longer shown
ex ex ex ex ex ex ex ex ex ex
image image image image image image image image image image

Brave startup calls

- Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile - Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

This was referenced Jul 27, 2023
Closed
Closed
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S7 using version:

Brave	1.58.57 Chromium: 116.0.5845.51 (Official Build) canary (64-bit) 
Revision	6c19156899db69697aa5667a5d61e8cf4a11f2f6
OS	Android 13; Build/TP1A.220624.014; 33; REL

Bottom toolbar N/A (Tablet)

Import/export bookmarks
  • Ensured import/export is working
Example Example Example Example
Screenshot 2023-07-31 at 5 00 52 PM Screenshot 2023-07-31 at 5 01 04 PM Screenshot 2023-07-31 at 5 01 42 PM Screenshot 2023-07-31 at 5 01 51 PM
Downloads
  • Ensured downloading files works and user is able to perform all actions on downloaded file
  • Ensured that enabling show download progress notifications will display toast notification for state changes to files being downloaded.
Example Example Example Example Example
Screenshot 2023-07-31 at 5 05 15 PM Screenshot 2023-07-31 at 5 05 29 PM Screenshot 2023-07-31 at 5 05 48 PM Screenshot 2023-07-31 at 5 06 07 PM Screenshot 2023-07-31 at 5 07 09 PM
Sync
  • Ensured creating standalone chain on device works
  • Ensured joining sync chain using QR code or code words works
  • Ensured sharing content using send to my devices works
  • Ensured bookmarks, history and autofill show up from other devices
Example Example Example Example Example Example
Screenshot 2023-07-31 at 5 08 38 PM Screenshot 2023-07-31 at 5 08 48 PM Screenshot 2023-07-31 at 5 09 00 PM Screenshot 2023-07-31 at 5 09 09 PM Screenshot 2023-07-31 at 5 09 28 PM Screenshot 2023-07-31 at 5 10 41 PM
Top toolbar
  • Ensured items in top toolbar perform appropriate action

@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 1, 2023 •
edited
Loading

Verified on Samsung Galaxy S21 using version:

Brave	1.58.57 Chromium: 116.0.5845.51 (Official Build) canary (64-bit) 
Revision	6c19156899db69697aa5667a5d61e8cf4a11f2f6
OS	Android 13; Build/TP1A.220624.014; 33; REL
Bottom toolbar
  • Ensured functionality on bottom toolbar
Import/export bookmarks
  • Ensured import/export is working
Example Example
Screenshot 2023-08-01 at 11 24 07 AM Screenshot 2023-08-01 at 11 24 21 AM
Downloads
  • Ensured downloading files works and user is able to perform all actions on downloaded file
  • Ensured that enabling show download progress notifications will display toast notification for state changes to files being downloaded.
Example Example Example
Screenshot 2023-08-01 at 11 33 54 AM Screenshot 2023-08-01 at 11 34 04 AM Screenshot 2023-08-01 at 11 34 25 AM
Sync
  • Ensured creating standalone chain on device works
  • Ensured joining sync chain using QR code or code words works
  • Ensured sharing content using send to my devices works
  • Ensured bookmarks, history and autofill show up from other devices
Example Example
Screenshot 2023-08-01 at 11 50 52 AM Screenshot 2023-08-01 at 11 51 19 AM
Top toolbar
  • Ensured items in top toolbar perform appropriate action

@kjozwiak
Copy link
Member

kjozwiak commented Aug 8, 2023

The above requires 1.57.42 or higher for 1.57.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Aug 9, 2023 •
edited
Loading

Tests below verified with 1.57.42, remaining testing to be completed via #32168 (comment) with updated version.

Brave	1.57.42 Chromium: 116.0.5845.51 (Official Build) (64-bit) 
Revision	e25036a089c476c56bf71774a898a1fee014e00d
OS	Linux
Changing shield settings works correctly - PASSED
Clean profile

Restart browser and verify updated shield settings retained

Case 1: Browser restart retain the updated site specific shield settings - PASSED

Trackers & ads blocking

Case 1:

  1. Clean profile
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block trackers and ads to Aggressive
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are retained

Case 2:

  1. Continue from above
  2. Open the same site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Aggressive to Block trackers and ads
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are retained

Case 3:

  1. Continue from above
  2. Open the same site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block trackers and ads to Allow all trackers and ads
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are retained

Block fingerprinting

Case 1:

  1. Clean profile
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block fingerprinting to Aggressive
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are retained

Case 2:

  1. Continue from above
  2. Open the same site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Aggressive to Block fingerprinting
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are retained

Case 3:

  1. Continue from above
  2. Open the same site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block fingerprinting to Allow fingerprinting
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are retained

Block cookies

Case 1:

  1. Clean profile
  2. Open the same site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block cross site cookies to Block all cookies
  5. Restart the browser
  6. Open the site shield settings, updated cookies settings are retained

Case 2:

  1. Continue from above
  2. Open the same site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block all cookies to Allow all cookies
  5. Restart the browser
  6. Open the site shield settings, updated cookies settings are retained

Case 3:

  1. Continue from above
  2. Open the same site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Allow all cookies to Block cross site cookies
  5. Restart the browser
  6. Open the site shield settings, updated cookies settings are retained
Case 2: Browser restart retain the updated global shield settings - PASSED

Trackers & ads blocking

Case 1:

  1. Clean profile
  2. Navigate to brave://settings/shields
  3. Change the trackers and ad blocking default settings from Standard to Aggressive
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are retained

Case 2:

  1. Continue from above
  2. Open the same site
  3. Change the trackers and ad blocking default settings from Aggressive to Disabled
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are retained

Case 3:

  1. Continue from above
  2. Open the same site
  3. Change the trackers and ad blocking default settings from Disabled to Standard
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured trackers and ad blocking settings are retained

Fingerprint blocking

Case 1:

  1. Clean profile
  2. Navigate to brave://settings/shields
  3. Change the fingerprinting default settings from Standard to Strict, may break sites
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are retained

Case 2:

  1. Continue from above
  2. Open the same site
  3. Change the fingerprinting default settings from Strict, may break sites to Disabled
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are retained

Case 3:

  1. Continue from above
  2. Open the same site
  3. Change the fingerprinting default settings from Disabled to Standard
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are retained

Cookies blocking

Case 1:

  1. Clean
  2. Navigate to brave://settings/shields
  3. Change the cookies default settings from Only cross site to All
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are retained

Case 2:

  1. Continue from above
  2. Open the same site
  3. Change the cookies default settings from All to Disabled
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are retained

Case 3:

  1. Continue from above
  2. Open the same site
  3. Change the cookies default settings from Disabled to Only cross sites
  4. Open a site and click on shield and ensured global shield settings are applied
  5. Restart the browser
  6. Open the site shield settings and ensured fingerprinting settings are retained

Site shield settings in Private window

Case 3: Verify that updated per site shield settings in Private window are NOT propagated to Normal window - PASSED
  • Make changes to shield settings in the Private tab (e.g Allow ads and trackers)
  • Go to the normal window and open CNN.com and confirm shield settings changes are NOT retained in the normal window
Upgrade profile
Case 1: Install 1.56.x CR 115 and upgrade it to 1.57.x CR 116 - PASSED

Case 1.1: Default shield settings upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 4. Upgrade the profile to  1.57.x CR 116
 5. Confirmed profile is upgraded to  1.57.x CR 116
 6. Confirmed default shield settings are retained

Case 1.2: Update the default shield settings and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Edit the site-specific shield settings
 5. Upgrade the profile to  1.57.x CR 116
 6. Confirmed profile is upgraded to  1.57.x CR 116
 7. Confirmed that updated shield settings are retained after the upgrade

Case 1.3: Update the global default shield settings and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Edit the global shield settings via brave://settings/shields
 5. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that updated global shield settings are retained after the upgrade

Case 1.4: Turn OFF the shield for a few sites and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Turn OFF the shield for a few sites via panel
 4. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that shield settings are retained after the upgrade

Case 1.5: Block scripts and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Block scripts for any of the sites via Panel or via brave://settings/shields
 5. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that script block settings are retained after the upgrade

Case 1.6: Block HTTPS upgrade and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Block HTTPS upgrade via Panel or via brave://settings/shields
 5. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that block HTTPS upgrade settings are retained after the upgrade
All items a present and work as expected in the ☰ menu - PASSED
  • Confirmed that all the menu items are present in the Hamburger menu
  • Confirmed that clicking on various menu items navigates to the intended page
1.56.x 1.57.x
1 56 1 57
Translate page - PASSED
  • Installed 1.57.42
  • Launch Brave, close and relaunch to pull griffin
  • visited https://www.publico.pt/
  • confirmed Brave translate functionality worked as expected (Portuguese to English)
  • confirmed when selected choose another - French, page translated as expected
  • confirmed when selected Never translate Portuguese, and reload the page, Brave translate icon is no longer shown
  • confirmed when selected Never translate this site, and reload the page, Brave translate icon is no longer shown
Example Example Example
1 2 3
Signing into Google sites works - PASSED

Case 1 - PASSED

  1. Clean profile 1.57.51 - CR116
  2. Restart the browser and if you don't see BraveGoogleSignInPermissionStudy:Enabled via brave://version, go to brave://flags and enable brave://flags/#brave-google-sign-in-permission and relaunch as necessary.
  3. Ensure that Google sign-in is visible via brave://settings/content (expand permissions list)
  4. Ensure that Sites can ask to use legacy Google Sign-In via third-party cookies is enabled
  5. Visit https://www.expensify.com and click on the Google login button
  6. Ensure that you receive the Allow use of third-party cookies for legacy Google sign-in modal without any issues
  7. Click on Allow and ensure it appears under Allowed to use third-party cookies for legacy Google Sign-In via brave://settings/content/googleSignIn
  8. Remove Expensify from Allowed to use third-party cookies for legacy Google Sign-In via brave://settings/content/googleSignIn
  9. Visit https://www.expensify.com and click on the Google login button (should get the modal once again)
  10. Click on Block and ensure it appears under Not allowed to use third-party cookies for legacy Google Sign-In via brave://settings/content/googleSignIn
  11. Remove Expensify from Not allowed to use third-party cookies for legacy Google Sign-In via brave://settings/content/googleSignIn
  12. Disable Google sign-in via Don't allow legacy Google Sign-In via third-party cookies under brave://settings/content/googleSignIn
  13. Visit https://www.expensify.com and click on the Google login button
  14. Ensure that a modal isn't being displayed/appearing
Example Example Example Example Example Example
Screenshot 2023-08-09 at 3 47 10 PM Screenshot 2023-08-09 at 3 47 20 PM Screenshot 2023-08-09 at 3 47 27 PM Screenshot 2023-08-09 at 3 48 00 PM Screenshot 2023-08-09 at 3 48 14 PM Screenshot 2023-08-09 at 3 48 48 PM
  1. Re-enabled Sites can ask to use legacy Google Sign-In via third-party cookies under brave://settings/content/googleSignIn
  2. Confirmed able to login with Google on expensify.com

Case 2 - PASSED

  1. Clean profile, close and relaunch to pull griffin
  2. With BraveGoogleSignInPermissionStudy:Disabled via brave://version, completed the following steps
  3. Confirmed Allow use of third-party cookies for legacy Google Sign-In was enabled via brave://settings/socialBlocking
  4. confirmed I could log in to expensify.com using SAML, with the above pref enabled
  5. toggled Allow use of third-party cookies for legacy Google Sign-In to OFF
  6. confirmed I could NOT log in to expensify with the above pref disabled
Example Example Example
Screenshot 2023-08-09 at 3 56 11 PM Screenshot 2023-08-09 at 3 57 42 PM Screenshot 2023-08-09 at 3 58 26 PM
Linux specific password checks - PASSED

Followed tests from https://gist.github.com/fmarier/224729615bd5e887b9ac29236288f7a1.

Case 1 - Saving a password directly - PASSED

Reference https://gist.github.com/fmarier/224729615bd5e887b9ac29236288f7a1#saving-a-password-in-a-new-profile.

  1. Exit any Brave Browser.
  2. Open the seahorse application.
  3. WARNING: continuing will wipe all of your passwords in ALL Brave profiles.
  4. Look for "Brave Safe Storage" and right-click on it. Delete.
  5. Close the seahorse application.
Example Example Example Example
1 2 3 4

Now, pick a website for which you'll save the password in Brave. I used https://www.libravatar.org/.

Now let's save the password in a new profile of Brave Release 1.57.42 Chromium: 116.0.5845.51:

pre-req: install 1.57.42 Chromium: 116.0.5845.51

  1. Start above version (can use brave-browser --user-data-dir=/home/francois/brave-temp-profile (replacing "francois" with your username).
  2. Visit the target website, login and save the password to the password manager.
  3. Check brave://settings/passwords to make sure the password was saved successfully.
  4. Close Brave.
Example Example
5 6
Case 2 - Looking at the password database directly - PASSED

Reference https://gist.github.com/fmarier/224729615bd5e887b9ac29236288f7a1#looking-at-the-password-database-directly.

Continuing from case 1, confirm that the password was saved in an encrypted way:

  1. Open seahorse again.
  2. Confirm that a new "Brave Safe Storage" entry was created.
2
  1. Close seahorse.
  2. Install sqlite3 using sudo apt install sqlite3.
  3. Open the password database manually: sqlite3 ~/brave-temp-profile/Default/Login\ Data
  4. List all passwords: select origin_url, username_value, password_value from logins;
  5. Confirm that the password_value (last column) starts with "v11" and not "v10".
lauren@lauren-virtual-machine:~$ sqlite3 ~/brave-temp-profile/Default/Login\ Data
SQLite version 3.37.2 2022-01-06 13:25:41
Enter ".help" for usage hints.
sqlite> select origin_url, username_value, password_value from logins;
https://www.libravatar.org/accounts/new/|l(redacted)|v11(redacted)
  1. Exit sqlite3 by pressing Ctrl+d.

Per https://gist.github.com/fmarier/224729615bd5e887b9ac29236288f7a1#looking-at-the-password-database-directly, since we see that "v11", it means that Brave was able to connect to gnome-keyring using gnome-libsecret since that's the only secure storage wallet available by default in Ubuntu.

Note - I "redacted" username and the unnecessary part of the password_value.

Case 3 - Opening an old password database using a new version of Brave - PASSED

Reference https://gist.github.com/fmarier/224729615bd5e887b9ac29236288f7a1#opening-an-old-password-database-using-a-new-version-of-brave.

  1. Delete the brave-temp-profile folder: rm -rf ~/brave-temp-profile
  2. Start Release (1.56.20) using brave-browser-stable --user-data-dir=/home/francois/brave-temp-profile (again, replacing "francois" with your own username)
  3. Visit the target website (I used ravelry.com this time), login and save the password to the password manager.
3
  1. Log out of the site.
  2. Check brave://settings/passwords to make sure the password was saved successfully.
5
  1. Close Brave.
  2. Follow the same sqlite3 procedure as before to check that the password was saved in "v11" format.
lauren@lauren-virtual-machine:~$ sqlite3 ~/brave-temp-profile/Default/Login\ Data
SQLite version 3.37.2 2022-01-06 13:25:41
Enter ".help" for usage hints.
sqlite> select origin_url, username_value, password_value from logins;
https://www.ravelry.com/account/login|l(redacted)|v11(redacted)
  1. Exit sqlite3 by pressing Ctrl+d.
  2. Uninstall 1.56.20 and install 1.57.42 with Chromium 116.
  3. Start the RC using brave-browser --user-data-dir=/home/francois/brave-temp-profile (change "francois" again)
  4. Check brave://settings/passwords to make sure the password is still readable.
Example Example
11a 11b
  1. Bonus points - visit site and login again using saved username/password.

If you can see the password in 1.57.x, that means that 1.57.x, using gnome-libsecret, can continue to read passwords that were saved in gnome-keyring (using the old library in Release 1.56.x with Chromium 115).

@stephendonner
Copy link

stephendonner commented Aug 9, 2023 •
edited
Loading

Verification IN-PROGRESS using

Brave | 1.57.42 Chromium: 116.0.5845.51 (Official Build) (x86_64)
-- | --
Revision | e25036a089c476c56bf71774a898a1fee014e00d
OS | macOS Version 11.7.9 (Build 20G1426)

Changing Shields settings works correctly - PASSED

New Profile - PASSED

  • confirmed defaults in brave://settings/shields
  • confirmed ability to change settings
  • confirmed settings are retained after browser restarts
  • confirmed items are blocked or allowed, accordingly

Trackers & ads blocking - PASSED

Default (Standard)

brave://settings/shields sfgate.com, defaults
Screen Shot 2023-08-09 at 11 48 46 AM Screen Shot 2023-08-09 at 11 47 21 AM

Disabled

brave://settings/shields sfgate.com, Allow all trackers & ads
Screen Shot 2023-08-09 at 12 10 25 PM Screen Shot 2023-08-09 at 11 48 21 AM

Block scripts - PASSED

Default (Off/Disabled)

brave://settings/shields blizzard.com, defaults
Screen Shot 2023-08-09 at 12 03 25 PM Screen Shot 2023-08-09 at 12 03 21 PM

Block scripts, ON

brave://settings/shields blizzard.com, Scripted blocked
Screen Shot 2023-08-09 at 12 00 36 PM Screen Shot 2023-08-09 at 12 00 44 PM

Block fingerprinting - PASSED

Default (Standard)

example example
Screen Shot 2023-08-09 at 12 28 47 PM Screen Shot 2023-08-09 at 12 29 17 PM

Strict, may break sites

example example
Screen Shot 2023-08-09 at 12 27 58 PM Screen Shot 2023-08-09 at 12 32 20 PM

Disabled

example example
Screen Shot 2023-08-09 at 12 33 36 PM Screen Shot 2023-08-09 at 12 34 08 PM

Block cookies - PASSED

Default (Only cross-site)

brave://settings/shields twitter.com (logged in via Google) brave://settings/content/all
Screen Shot 2023-08-09 at 1 04 01 PM Screen Shot 2023-08-09 at 1 26 48 PM Screen Shot 2023-08-09 at 1 27 01 PM

Block cookies, All

brave://settings/shields twitter.com brave://settings/content/all
Screen Shot 2023-08-09 at 1 07 23 PM Screen Shot 2023-08-09 at 1 20 05 PM Screen Shot 2023-08-09 at 1 19 14 PM

Block cookies, Disabled

brave://settings/shields twitter.com brave://settings/content/all
Screen Shot 2023-08-09 at 1 08 37 PM Screen Shot 2023-08-09 at 1 24 12 PM Screen Shot 2023-08-09 at 1 10 14 PM

Upgraded profile - PASSED

Install 1.56.x CR 115 and upgrade it to 1.57.x CR 116 - PASSED

Case 1.1: Default shield settings upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 4. Upgrade the profile to  1.57.x CR 116
 5. Confirmed profile is upgraded to  1.57.x CR 116
 6. Confirmed default shield settings are retained

Case 1.2: Update the default shield settings and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Edit the site-specific shield settings
 5. Upgrade the profile to  1.57.x CR 116
 6. Confirmed profile is upgraded to  1.57.x CR 116
 7. Confirmed that updated shield settings are retained after the upgrade

Case 1.3: Update the global default shield settings and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Edit the global shield settings via brave://settings/shields
 5. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that updated global shield settings are retained after the upgrade

Case 1.4: Turn OFF the shield for a few sites and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Turn OFF the shield for a few sites via panel
 4. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that shield settings are retained after the upgrade

Case 1.5: Block scripts and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Block scripts for any of the sites via Panel or via brave://settings/shields
 5. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that script block settings are retained after the upgrade

Case 1.6: Block HTTPS upgrade and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Block HTTPS upgrade via Panel or via brave://settings/shields
 5. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that block HTTPS upgrade settings are retained after the upgrade

All items are present and work as expected in the ☰ menu - PASSED

Screen Shot 2023-08-09 at 10 12 04 AM

Note: encountered the menu-item string changes from Chromium 116 mentioned here: https://bravesoftware.slack.com/archives/CU5UXM3EC/p1690561214082359?thread_ts=1690227069.794059&cid=CU5UXM3EC

Translate page works - PASSED

  • confirmed I could translate from Ukranian to English on https://www.pravda.com.ua/
  • confirmed I could translate from Spanish to English on esmas.com
  • confirmed I could translate from Spanish to English and then to Afrikaans, on esmas.com
example example example example example example
Screen Shot 2023-08-09 at 10 45 51 AM Screen Shot 2023-08-09 at 10 46 09 AM Screen Shot 2023-08-09 at 10 48 26 AM Screen Shot 2023-08-09 at 10 48 37 AM Screen Shot 2023-08-09 at 10 48 53 AM Screen Shot 2023-08-09 at 10 49 06 AM

Signing into Google sites works - PASSED

  • confirmed Allow use of third-party cookies for legacy Google Sign-In was enabled via brave://settings/socialBlocking
  • confirmed I could log in to expensify.com using SAML, with the above pref enabled
  • toggled Allow use of third-party cookies for legacy Google Sign-In to OFF
  • confirmed I could NOT log in to expensify with the above pref disabled
example example example example
Screen Shot 2023-08-09 at 10 30 48 AM Screen Shot 2023-08-09 at 10 34 50 AM Screen Shot 2023-08-09 at 10 31 58 AM Screen Shot 2023-08-09 at 10 32 01 AM

Brave Side Panel looks/works correctly - PASSED

  • Confirmed that sidebar is NOT shown by default
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR, and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
  • Confirmed that tooltip is shown correctly for each menu item in sidebar
  • Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and Reading list works as expected

Clear browsing data for time span works - PASSED

Basic - last hour - PASSED

  1. install 1.57.42
  2. launched Brave
  3. browsed a few sites
  4. logged in to a few sites
  5. clicked on Brave -> Clear Browsing Data...
  6. unchecked Cookies and other site data
  7. clicked Clear data
  8. confirmed brave://history was empty
  9. confirmed I was still signed in to gmail.com
  10. returned to brave://settings/clearBrowserData
  11. checked Cookies and other site data
  12. clicked Clear data
  13. confirmed I was no longer signed in
  14. confirmed brave://history was cleared
example example example example example
Screen Shot 2023-08-09 at 4 02 08 PM Screen Shot 2023-08-09 at 4 02 18 PM Screen Shot 2023-08-09 at 4 02 36 PM Screen Shot 2023-08-09 at 4 05 22 PM Screen Shot 2023-08-09 at 4 05 37 PM

Advanced - all time - PASSED

  1. install 1.57.42
  2. launched Brave
  3. browsed a few sites
  4. logged in to a few sites
  5. clicked on Brave -> Clear Browsing Data...
  6. clicked on the Advanced tab
  7. selected All time from Time range
  8. clicked Clear data
  9. confirmed I was no longer signed in
  10. confirmed brave://history was cleared
example example example example example
Screen Shot 2023-08-09 at 4 27 03 PM Screen Shot 2023-08-09 at 4 40 26 PM Screen Shot 2023-08-09 at 4 27 22 PM Screen Shot 2023-08-09 at 4 34 16 PM Screen Shot 2023-08-09 at 4 27 15 PM

Advanced - last 7 days - PASSED

Wednesday, August 9th clear Last 7 days Wednesday, August 2nd
Screen Shot 2023-08-09 at 5 10 10 PM Screen Shot 2023-08-09 at 5 03 42 PM Screen Shot 2023-08-09 at 5 03 56 PM

Advanced - last 4 weeks - PASSED

Wednesday, Aug 9th clear cache example clear cache and history Tuesday, Jul 11th
Screen Shot 2023-08-09 at 5 32 01 PM Screen Shot 2023-08-09 at 5 38 49 PM Screen Shot 2023-08-09 at 5 39 08 PM Screen Shot 2023-08-09 at 5 40 19 PM Screen Shot 2023-08-09 at 5 40 29 PM

Omnibox suggestions are shown when enabled - PASSED

  • confirmed default of no search suggestions when typing san mateo weather (and assorted searches) in the URL bar
  • confirmed Improve search suggestions is set to OFF in brave://settings/search
  • toggled Improve search suggestions to ON
  • typed san mateo weather again
  • confirmed I saw search-autocomplete suggestions in the URL bar
  • confirmed Improve search suggestions, when enabled, has no effect in both Private and Private w/Tor windows
Improve search suggestions, OFF Improve search suggestions, ON
Screen Shot 2023-08-09 at 11 04 33 AM Screen Shot 2023-08-09 at 11 04 23 AM
Improve search suggestions, ON Private window Private w/Tor window Guest window
Screen Shot 2023-08-09 at 11 12 57 AM Screen Shot 2023-08-09 at 11 13 14 AM Screen Shot 2023-08-09 at 11 13 41 AM Screen Shot 2023-08-09 at 11 19 53 AM

Note: encountered the menu-item string changes from Chromium 116 mentioned here: https://bravesoftware.slack.com/archives/CU5UXM3EC/p1690561214082359?thread_ts=1690227069.794059&cid=CU5UXM3EC

Installation and upgrade work (upgrade 1.56.x -> 1.57.x and 1.57.x to 1.57.x) - PENDING

1.56.x -> 1.57.x - PASSED

Done as part of the Shields-profile upgrade work, see above

1.57.42 -> 1.57.44 - PENDING

Update from 1.57.42 to 1.57.44

@kjozwiak kjozwiak mentioned this issue Aug 10, 2023
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Aug 10, 2023 •
edited
Loading

Labelling as QA/No & release-notes/exclude in favour of #32168. @LaurenWags @stephendonner once done, can basically copy/paste the above into #32168 👍

@kjozwiak kjozwiak removed the QA/Yes label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

@cdesouza-chromium cdesouza-chromium

@mkarolin mkarolin

Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass - Android ARM QA Pass - Android Tab QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 115 to Chromium 116 brave/brave-core
9 participants
@stephendonner @kjozwiak @Uni-verse @LaurenWags @samartnik @cdesouza-chromium @GeetaSarvadnya @mkarolin @brave-builds