Upgrade from Chromium 116.0.5845.62 to Chromium 116.0.5845.82.

[mkarolin]

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/116.0.5845.62..116.0.5845.82?pretty=fuller&n=10000

QA tests:

• Check branding items
• Check for version bump

Additional checks:

• No specific code changes in Brave (only line number changes in patches)

[kjozwiak]

The above requires 1.57.44 or higher for 1.57.x verification 👍

[kjozwiak]

Quick overview of the work remaining re: affected areas due to C116 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #30747 (comment).

• Windows - Requires quick spot check, full check completed via Upgrade from Chromium 115 to Chromium 116. #30747 (comment).
• Android ARM - Requires quick spot check, full check completed via Upgrade from Chromium 115 to Chromium 116. #30747 (comment).
• Android Tablet - affected areas completed via Upgrade from Chromium 115 to Chromium 116. #30747 (comment)

Platforms that still need to check/verify the affected areas due to C116 changes as per #30747 (comment).

• macOS - currently in progress by @stephendonner via Upgrade from Chromium 115 to Chromium 116. #30747 (comment)
• Linux - currently in progress by @LaurenWags via Upgrade from Chromium 115 to Chromium 116. #30747 (comment).

[stephendonner]

Verification PASSED using

Brave | 1.57.44 Chromium: 116.0.5845.82 (Official Build) (x86_64)
-- | --
Revision | 109e984111c5152478bf49d266f4e19861c0b63e
OS | macOS Version 11.7.9 (Build 20G1426)

Previous tests (which I copied and supplanted here) can be found here: #30747 (comment)

Substantial testing using the below version, prior:

Brave | 1.57.42 Chromium: 116.0.5845.51 (Official Build) (x86_64)
-- | --
Revision | e25036a089c476c56bf71774a898a1fee014e00d
OS | macOS Version 11.7.9 (Build 20G1426)

Changing Shields settings works correctly - PASSED

New Profile - PASSED

• confirmed defaults in brave://settings/shields
• confirmed ability to change settings
• confirmed settings are retained after browser restarts
• confirmed items are blocked or allowed, accordingly

Trackers & ads blocking - PASSED

Default (Standard)

brave://settings/shields	sfgate.com, defaults

Disabled

brave://settings/shields	sfgate.com, Allow all trackers & ads

Block scripts - PASSED

Default (Off/Disabled)

brave://settings/shields	blizzard.com, defaults

Block scripts, ON

brave://settings/shields	blizzard.com, Scripted blocked

Block fingerprinting - PASSED

Default (Standard)

example	example

Strict, may break sites

example	example

Disabled

example	example

Block cookies - PASSED

Default (Only cross-site)

brave://settings/shields	twitter.com (logged in via Google)	brave://settings/content/all

Block cookies, All

brave://settings/shields	twitter.com	brave://settings/content/all

Block cookies, Disabled

brave://settings/shields	twitter.com	brave://settings/content/all

Upgraded profile - PASSED

Install 1.56.x CR 115 and upgrade it to 1.57.x CR 116 - PASSED

Case 1.1: Default shield settings upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 4. Upgrade the profile to  1.57.x CR 116
 5. Confirmed profile is upgraded to  1.57.x CR 116
 6. Confirmed default shield settings are retained

Case 1.2: Update the default shield settings and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Edit the site-specific shield settings
 5. Upgrade the profile to  1.57.x CR 116
 6. Confirmed profile is upgraded to  1.57.x CR 116
 7. Confirmed that updated shield settings are retained after the upgrade

Case 1.3: Update the global default shield settings and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Edit the global shield settings via brave://settings/shields
 5. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that updated global shield settings are retained after the upgrade

Case 1.4: Turn OFF the shield for a few sites and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Turn OFF the shield for a few sites via panel
 4. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that shield settings are retained after the upgrade

Case 1.5: Block scripts and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Block scripts for any of the sites via Panel or via brave://settings/shields
 5. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that script block settings are retained after the upgrade

Case 1.6: Block HTTPS upgrade and then upgrade - PASSED

 1. Clean profile 1.56.x
 2. Open a few websites 
 3. Block HTTPS upgrade via Panel or via brave://settings/shields
 5. Upgrade the profile to 1.57.x CR 116
 6. Confirmed profile is upgraded to 1.57.x CR 116
 7. Confirmed that block HTTPS upgrade settings are retained after the upgrade

All items are present and work as expected in the ☰ menu - PASSED

Note: encountered the menu-item string changes from Chromium 116 mentioned here: https://bravesoftware.slack.com/archives/CU5UXM3EC/p1690561214082359?thread_ts=1690227069.794059&cid=CU5UXM3EC

Translate page works - PASSED

• confirmed I could translate from Ukranian to English on https://www.pravda.com.ua/
• confirmed I could translate from Spanish to English on esmas.com
• confirmed I could translate from Spanish to English and then to Afrikaans, on esmas.com

example	example	example	example	example	example

Signing into Google sites works - PASSED

• confirmed Allow use of third-party cookies for legacy Google Sign-In was enabled via brave://settings/socialBlocking
• confirmed I could log in to expensify.com using SAML, with the above pref enabled
• toggled Allow use of third-party cookies for legacy Google Sign-In to OFF
• confirmed I could NOT log in to expensify with the above pref disabled

example	example	example	example

Brave Side Panel looks/works correctly - PASSED

• Confirmed that sidebar is NOT shown by default
• Confirmed that Reading list icon is added to the sidebar menu
• Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
• Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
• Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
• Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
• Confirmed that reading list icon is shown in the URL bar, next to wallet icon
• Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
• Confirmed that reading list is shown in all the window types (Normal, PT, TOR, and Guest window)
• Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
• Confirmed that sites can be segregated to Read and Unread list
• Confirmed that sites can be deleted from the reading list
• Confirmed that tooltip is shown correctly for each menu item in sidebar
• Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and Reading list works as expected

Clear browsing data for time span works - PASSED

Basic - last hour - PASSED

1. install 1.57.42
2. launched Brave
3. browsed a few sites
4. logged in to a few sites
5. clicked on Brave -> Clear Browsing Data...
6. unchecked Cookies and other site data
7. clicked Clear data
8. confirmed brave://history was empty
9. confirmed I was still signed in to gmail.com
10. returned to brave://settings/clearBrowserData
11. checked Cookies and other site data
12. clicked Clear data
13. confirmed I was no longer signed in
14. confirmed brave://history was cleared

example	example	example	example	example

Advanced - all time - PASSED

1. install 1.57.42
2. launched Brave
3. browsed a few sites
4. logged in to a few sites
5. clicked on Brave -> Clear Browsing Data...
6. clicked on the Advanced tab
7. selected All time from Time range
8. clicked Clear data
9. confirmed I was no longer signed in
10. confirmed brave://history was cleared

example	example	example	example	example

Advanced - last 7 days - PASSED

Wednesday, August 9th	clear Last 7 days	Wednesday, August 2nd

Advanced - last 4 weeks - PASSED

Wednesday, Aug 9th	clear cache	example	clear cache and history	Tuesday, Jul 11th

Omnibox suggestions are shown when enabled - PASSED

• confirmed default of no search suggestions when typing san mateo weather (and assorted searches) in the URL bar
• confirmed Improve search suggestions is set to OFF in brave://settings/search
• toggled Improve search suggestions to ON
• typed san mateo weather again
• confirmed I saw search-autocomplete suggestions in the URL bar
• confirmed Improve search suggestions, when enabled, has no effect in both Private and Private w/Tor windows

Improve search suggestions, OFF	Improve search suggestions, ON

Improve search suggestions, ON	Private window	Private w/Tor window	Guest window

Note: encountered the menu-item string changes from Chromium 116 mentioned here: https://bravesoftware.slack.com/archives/CU5UXM3EC/p1690561214082359?thread_ts=1690227069.794059&cid=CU5UXM3EC

Installation and upgrade work (upgrade 1.56.x -> 1.57.x and 1.57.x to 1.57.x) - PASSED

Update from 1.56.x to 1.57.x - PASSED

Done as part of the Shields-profile upgrade work, see above

Update from 1.57.42 to1.57.44 - PASSED

Steps:

1. installed 1.57.42
2. launched Brave using a seeded profile, and commandline: ./Brave\ Browser --update-feed-url=https://updates.bravesoftware.com/sparkle/Brave-Browser/test/appcast.xml --enable-logging=stderr
3. loaded brave://settings/help
4. confirmed it checked for an update
5. confirmed it found an update
6. clicked on the Relaunch button
7. confirmed I was updated to 1.57.44 and the profile was intact

1.57.42	updating Brave	clicked relaunch	1.57.44

[LaurenWags]

Verified with

Brave	1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit) 
Revision	109e984111c5152478bf49d266f4e19861c0b63e
OS	Linux

Previous testing completed with #30747 (comment) includes:

• Changing shield settings works correctly (PASSED)
• All items a present and work as expected in the ☰ menu (PASSED)
• Translate page (PASSED)
• Signing into Google sites works (PASSED)
• Linux specific password checks (PASSED)

Resuming testing with:

Brave Side Panel looks/works as expected - PASSED

• Confirmed that sidebar is not shown by default in the release channel
• Confirmed that Reading list icon is added to the sidebar menu
• Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
• Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
• Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
• Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
• Confirmed that reading list icon is shown in the URL bar, next to wallet icon
• Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
• Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
• Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
• Confirmed that sites can be segregated to Read and Unread list
• Confirmed that sites can be deleted from the reading list
• Confirmed that tooltip is shown correctly for each menu item in sidebar
• Confirmed that click on each side panel button Brave Talk, wallet, Bookmarks and Reading list works as expected

Clear browsing data for time span works - PASSED

Basic - last hour - PASSED

1. install 1.57.4x
2. launched Brave
3. browsed a few sites
4. logged in to a few sites, closed these tabs
5. clicked on Brave -> Clear Browsing Data...
6. unchecked Cookies and other site data
7. clicked Clear data
8. confirmed brave://history was empty
9. confirmed I was still signed in to libravatar.org, closed this tab
10. returned to brave://settings/clearBrowserData
11. checked Cookies and other site data
12. clicked Clear data
13. confirmed I was no longer signed in
14. confirmed brave://history was cleared

example	example	example	example	example	example

Advanced - all time - PASSED

1. install 1.57.x
2. launched Brave
3. browsed a few sites
4. logged in to a few sites
5. Set up additional data (downloads, site specific shield settings, etc)
6. clicked on Brave -> Clear Browsing Data...
7. clicked on the Advanced tab
8. selected All time from Time range
9. Selected all items
10. clicked Clear data
11. confirmed I was no longer signed in
12. confirmed brave://history was cleared
13. Confirmed other items (downloads, site specific shield settings, etc) were cleared

example	example	example	example	example	example

Omnibox suggestions are shown when enabled - PASSED

1. Confirm that the Show autocomplete suggestions in address bar switch is enabled by default under brave://settings/appearance
2. Open a new tab and enter the string Buzz in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list
3. Go to brave://settings/appearance and uncheck/disable the checkbox Top sites
4. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled
5. Open the buzzfeed.com in any tab
6. Keep the Top sites still disabled/unchecked
7. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the Browsing History list
8. Go to brave://settings/appearance and uncheck/disable the checkbox Browsing History and keep Top sites as it is in step 6
9. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites and browsing history toggles are disabled/unchecked
10. Bookmark the site buzzfeed.com which is already opened in step 5 and close the tab
11. Keep the brave://settings/appearance setting as it is
12. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the Bookmarks list
13. Go to brave://settings/appearance and uncheck Bookmarks (all the 3 settings checkboxes are unchecked in this step)
14. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites , browsing history and bookmarks toggles are disabled/unchecked
15. Enable alll the 3 switches under Show autocomplete suggestions in address bar main switch
16. Disable the main switch Show autocomplete suggestions in address bar
17. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as Show autocomplete suggestions in address bar main switch is OFF

step 2	step 3	step 4	step 7	step 8	step 9	step 10	step 11	step 12	step 13	step 14	step 15	step 16	step 17

[Uni-verse]

Verified on Samsung Galaxy Tab S7 using version(s):

Brave	1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit) 
Revision	109e984111c5152478bf49d266f4e19861c0b63e
OS	Android 13; Build/TP1A.220624.014; 33; REL

• Check branding items
• Check for version bump
• Spot checked Android affected areas mentioned in Upgrade from Chromium 115 to Chromium 116. #30747 (comment)

Example	Example

[Uni-verse]

Verified on Samsung Galaxy S21 5G using version(s):

Brave	1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit) 
Revision	109e984111c5152478bf49d266f4e19861c0b63e
OS	Android 13; Build/TP1A.220624.014; 33; REL

• Check branding items
• Check for version bump
• Spot checked Android affected areas mentioned in Upgrade from Chromium 115 to Chromium 116. #30747 (comment)

Example	Example

[MadhaviSeelam]

Verification PASSED using

Brave | 1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit)
-- | --
Revision | 109e984111c5152478bf49d266f4e19861c0b63e
OS | Windows 11 Version 22H2 (Build 22621.2134)

[LaurenWags]

Changed to QA/No and release-notes/exclude as this is superseded by #32241