Crash on getting a profile

[SergeyZhukovsky]

I found that crash on GPS on a stable channel on 1.52.117.

Exception java.lang.RuntimeException:
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3762)
  at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3929)
  at android.app.servertransaction.LaunchActivityItem.execute (LaunchActivityItem.java:103)
  at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2284)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loopOnce (Looper.java:210)
  at android.os.Looper.loop (Looper.java:299)
  at android.app.ActivityThread.main (ActivityThread.java:8302)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:556)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1037)
Caused by java.lang.RuntimeException:
  at org.chromium.base.task.PostTask.runSynchronouslyInternal (PostTask.java:173)
  at org.chromium.base.task.PostTask.runSynchronously (PostTask.java:144)
  at org.chromium.base.ThreadUtils.runOnUiThreadBlocking (ThreadUtils.java:164)
  at org.chromium.chrome.browser.BraveIntentHandler.getWebSearchUrl (BraveIntentHandler.java:82)
  at org.chromium.chrome.browser.BraveIntentHandler.extractUrlFromIntent (BraveIntentHandler.java:58)
  at org.chromium.chrome.browser.IntentHandler.getUrlFromIntent (IntentHandler.java:1246)
  at org.chromium.chrome.browser.LaunchIntentDispatcher.dispatch (LaunchIntentDispatcher.java:162)
  at org.chromium.chrome.browser.LaunchIntentDispatcher.dispatch (LaunchIntentDispatcher.java:94)
  at org.chromium.chrome.browser.document.ChromeLauncherActivity.onCreate (ChromeLauncherActivity.java:33)
  at android.app.Activity.performCreate (Activity.java:8191)
  at android.app.Activity.performCreate (Activity.java:8159)
  at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1330)
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:3735)
Caused by java.util.concurrent.ExecutionException:
  at java.util.concurrent.FutureTask.report (FutureTask.java:122)
  at java.util.concurrent.FutureTask.get (FutureTask.java:191)
  at org.chromium.base.task.PostTask.runSynchronouslyInternal (PostTask.java:171)
  at org.chromium.base.task.PostTask.runSynchronously (PostTask.java:144)
Caused by java.lang.IllegalStateException: Browser hasn't finished initialization yet!
  at org.chromium.chrome.browser.profiles.Profile.getLastUsedRegularProfile (Profile.java:54)
  at org.chromium.chrome.browser.BraveIntentHandler$1.call (BraveIntentHandler.java:86)
  at org.chromium.chrome.browser.BraveIntentHandler$1.call (BraveIntentHandler.java:82)
  at java.util.concurrent.FutureTask.run (FutureTask.java:264)
  at org.chromium.base.task.PostTask.runOrPostTask (PostTask.java:111)
  at org.chromium.base.task.PostTask.runSynchronouslyInternal (PostTask.java:169)
  at org.chromium.base.task.PostTask.runSynchronously (PostTask.java:144)

I can't reproduce it, but the steps to verify that everything works are:

1. Go to gmail for example.
2. Select some text there and hit Web search
3. Pick Brave there.
   

[samartnik]

I was able to reproduce it with these steps (Pixel 6, Android 13, Brave Nightly):

1. Launch Brave
2. Close all applications from system menu
3. Open Gmail, long tap on any text there and select Web Search
4. Here it shows crash dialog (sometimes there is no dialog but crash logs in logcat)

[hffvld]

Verified on Google Pixel 7 using version(s):

Device/OS: Google Pixel 7 [panther_beta-user 14 UPB2.230407.014 release-keys]
Brave build: 1.54.31
Chromium: 114.0.5735.90 (Official Build) canary (64-bit)
Revision: 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}

---

STEPS:

1. Close all apps
2. Launch Gmail > Open any email
3. Long tap on any text > Web search
4. Open with Brave Nightly > Verify no crash observed

ACTUAL RESULTS:

• Verified that no crash was observed when opening Brave through Web search option in the apps
• Verified that Brave opened and show the correct info

NOTE: Tried to reproduce it more than 15 times on Nightly with zero repro rate (Still able to repro it with Beta and Prod builds just to compare it)

timestamp_13-01-33_13-02-08.mp4

[kjozwiak]

Removed QA Pass - Android ARM as we'll need to get the above verified via 1.52.x once we get RC builds.

[kjozwiak]

The above requires 1.52.120 or higher for 1.52.x verification 👍

[hffvld]

Verified on Google Pixel 6 using version(s):

Device/OS: Google Pixel 6 [oriole-user 13 TQ2A.230505.002 release-keys]
Brave build: 1.52.120
Chromium: 114.0.5735.90 (Official Build) (64-bit)
Revision: 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}

---

STEPS:

1. Close all apps
2. Launch Gmail > Open any email
3. Long tap on any text > Web search
4. Open with Brave Nightly > Verify no crash observed

ACTUAL RESULTS:

• Verified that no crash was observed when opening Brave through Web search option in the apps
• Verified that Brave opened and show the correct info

timestamp_16-57-13_16-58-01.mp4