-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a check whether browser initialised or not inside Intent Handler on Android #18736
Conversation
eb92f89
to
b2703a0
Compare
@@ -74,7 +75,8 @@ protected static String getWebSearchUrl(Intent intent) { | |||
} | |||
|
|||
String query = IntentUtils.safeGetStringExtra(intent, SearchManager.QUERY); | |||
if (query == null || TextUtils.isEmpty(query)) { | |||
if (TextUtils.isEmpty(query) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per @AlexeyBarabash 's suggestion removed query == null
as TextUtils.isEmpty
checks on null inside
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Verified on
STEPS:
ACTUAL RESULTS:
NOTE: Tried to reproduce it more than 15 times on Nightly with zero repro rate (Still able to repro it with Beta and Prod builds just to compare it) timestamp_13-01-33_13-02-08.mp4 |
Resolves brave/brave-browser#30773
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
It's described in the original issue.