Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check whether browser initialised or not inside Intent Handler on Android #18736

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#30773

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

It's described in the original issue.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Jun 2, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jun 2, 2023
@SergeyZhukovsky SergeyZhukovsky force-pushed the android_intent_handler_crash branch from eb92f89 to b2703a0 Compare June 2, 2023 14:39
@@ -74,7 +75,8 @@ protected static String getWebSearchUrl(Intent intent) {
}

String query = IntentUtils.safeGetStringExtra(intent, SearchManager.QUERY);
if (query == null || TextUtils.isEmpty(query)) {
if (TextUtils.isEmpty(query)
Copy link
Member Author

@SergeyZhukovsky SergeyZhukovsky Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per @AlexeyBarabash 's suggestion removed query == null as TextUtils.isEmpty checks on null inside

@AlexeyBarabash AlexeyBarabash self-requested a review June 2, 2023 14:40
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hffvld
Copy link
Collaborator

hffvld commented Jun 2, 2023

Verified on Google Pixel 7 using version(s):

Device/OS: Google Pixel 7 [panther_beta-user 14 UPB2.230407.014 release-keys]
Brave build: 1.54.31
Chromium: 114.0.5735.90 (Official Build) canary (64-bit)
Revision: 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}

STEPS:

  1. Close all apps
  2. Launch Gmail > Open any email
  3. Long tap on any text > Web search
  4. Open with Brave Nightly > Verify no crash observed

ACTUAL RESULTS:

  • Verified that no crash was observed when opening Brave through Web search option in the apps
  • Verified that Brave opened and show the correct info

NOTE: Tried to reproduce it more than 15 times on Nightly with zero repro rate (Still able to repro it with Beta and Prod builds just to compare it)

timestamp_13-01-33_13-02-08.mp4

kjozwiak pushed a commit that referenced this pull request Jun 2, 2023
… on Android (uplift to 1.53.x) (#18741)

Uplift of #18736 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Jun 2, 2023
… on Android (uplift to 1.52.x) (#18742)

Uplift of #18736 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on getting a profile
4 participants