Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge "DNSLink" and "Redirect gateway-like resouces" settings into the one #31097

Closed
cypt4 opened this issue Jun 16, 2023 · 1 comment · Fixed by brave/brave-core#18940
Closed

Merge "DNSLink" and "Redirect gateway-like resouces" settings into the one #31097

cypt4 opened this issue Jun 16, 2023 · 1 comment · Fixed by brave/brave-core#18940
Assignees
@cypt4
Labels
feature/settings feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@cypt4
Copy link

cypt4 commented Jun 16, 2023 •
edited
Loading

This two settings should be merged into a new one setting
image

Label: "Automatically redirect resources available on IPFS network to the configured gateway."
Description:
"Requests to IPFS resources, hosted on third-party IPFS gateways or DNSLINK resources will be loaded via selected local or remote gateway. Note: If local node is selected, resource will be requested directly from your computer and cached data may be provided to the IPFS network for some time."
Default value depends on values of the above settings. True if any was enabled.
@cypt4 cypt4 self-assigned this Jun 16, 2023
@cypt4 cypt4 added this to Web3 Jun 16, 2023
cypt4 added a commit to brave/brave-core that referenced this issue Jun 16, 2023
@cypt4
Merge "DNSLink" and "Redirect gateway-like resouces" settings into th…
6602e43 
…e one

Resolves brave/brave-browser#31097
@cypt4 cypt4 mentioned this issue Jun 16, 2023
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Jun 27, 2023
@cypt4
Merge "DNSLink" and "Redirect gateway-like resouces" settings into th…
870aa10 
…e one

Resolves brave/brave-browser#31097
cypt4 added a commit to brave/brave-core that referenced this issue Jun 28, 2023
@cypt4
Merge "DNSLink" and "Redirect gateway-like resouces" settings (#18940)
9153da3 
* Merge "DNSLink" and "Redirect gateway-like resouces" settings into the one
Resolves brave/brave-browser#31097
@github-project-automation github-project-automation bot moved this to Done in Web3 Jun 28, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 28, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.106 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision 601f5c9afccc48f581021ae0e0ee6c85b58821d2
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#18940
  • Verified upgrading to new build removes the two settings and combines into one setting
  • Verified if both DNS and IPFS gateway setting is enabled before upgrade, the new setting remains enabled after upgrade
  • Verified if only one of the setting is enabled, post upgrade the new setting is in disabled state
DNS Setting Enabled IPFS Gateway setting Enabled Both setting enabled
31097-.DNS.Link.Setting.Enabled.mp4
31097-.IPFS.Gateway.Setting.Enabled.mp4
31097.-.Both.Settings.Enabled.mp4

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/settings feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Merge "DNSLink" and "Redirect gateway-like resouces" settings brave/brave-core
3 participants
@srirambv @brave-builds @cypt4