Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading skeleton to after refreshing NFT page. #31485

Closed
HEagle18 opened this issue Jul 6, 2023 · 5 comments · Fixed by brave/brave-core#19418
Closed

Add loading skeleton to after refreshing NFT page. #31485

HEagle18 opened this issue Jul 6, 2023 · 5 comments · Fixed by brave/brave-core#19418
Assignees
@muliswilliam
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@HEagle18
Copy link

HEagle18 commented Jul 6, 2023

Description

Currently, when you refresh the NFT page , the user doesn't know that the page is being refreshed.
Link to conversation here https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1688551278398419

Attempting.Refresh.mov

cc @minkyeongshin for designs

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@HEagle18 HEagle18 added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jul 6, 2023
@HEagle18 HEagle18 added this to Web3 Jul 6, 2023
@minkyeongshin
Copy link

Design link
https://www.figma.com/file/muVcmcu4RFNu0LkXe9VRDl/Wallet-2.0?type=design&node-id=5012%3A350339&mode=design&t=bxH3aUjWUfYs1Jlg-1

@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jul 7, 2023
@muliswilliam muliswilliam mentioned this issue Jul 25, 2023
Merged
25 tasks
@muliswilliam muliswilliam moved this from Backlog to In Review in Web3 Jul 25, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Aug 8, 2023
@brave-builds brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Aug 8, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Aug 8, 2023
@LaurenWags
Copy link
Member

@muliswilliam please add the appropriate missing labels:

  • QA/Yes or QA/No
  • release-notes/include or release-notes/exclude

cc @HEagle18 @kjozwiak @rebron

@muliswilliam
Copy link

@LaurenWags Done.

@srirambv
Copy link
Contributor

srirambv commented Sep 5, 2023

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Linux
31485.mp4

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Windows 11 Version 22H2 (Build 22621.2215)
31485.mp4

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (arm64)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS macOS Version 13.4.1 (c) (Build 22F770820d)
31485.mov

@srirambv srirambv added QA Pass-Win64 QA Pass-macOS QA Pass-Linux and removed OS/Android Fixes related to Android browser functionality labels Sep 5, 2023
@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2023

Removed OS/Android as it requires Android specific implementation. cc: @Pavneet-Sing to log an issue if its already not addressed in another Android specific issue

@Pavneet-Sing Pavneet-Sing mentioned this issue Sep 6, 2023
Open
@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add loading skeleton and spinner to NFT tab brave/brave-core
6 participants
@HEagle18 @srirambv @LaurenWags @brave-builds @muliswilliam @minkyeongshin