Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Add loading skeleton and spinner to NFT tab #19418

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

muliswilliam
Copy link
Contributor

Resolves brave/brave-browser#31485

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.2023-07-25.at.19.14.43.mov

@muliswilliam muliswilliam requested review from a team as code owners July 25, 2023 16:35
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Jul 25, 2023
@muliswilliam muliswilliam force-pushed the feat-nft-discovery-loader branch from 16d786d to 399ca36 Compare July 25, 2023 16:38
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@muliswilliam muliswilliam force-pushed the feat-nft-discovery-loader branch 2 times, most recently from 4948e16 to 986c8e0 Compare July 27, 2023 14:05
@muliswilliam muliswilliam force-pushed the feat-nft-discovery-loader branch 2 times, most recently from d8cec27 to d4fd209 Compare August 7, 2023 17:12
@muliswilliam muliswilliam force-pushed the feat-nft-discovery-loader branch from d4fd209 to b7cb9c0 Compare August 8, 2023 08:36
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam merged commit 06b6588 into master Aug 8, 2023
@muliswilliam muliswilliam deleted the feat-nft-discovery-loader branch August 8, 2023 10:39
@github-actions github-actions bot added this to the 1.58.x - Nightly milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loading skeleton to after refreshing NFT page.
5 participants