Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual cookies can't be accessed properly in some domains through brave://settings/content/all when "subdomains" exist. #31690

Open
ghost opened this issue Jul 17, 2023 · 2 comments
Labels
feature/cookies feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@ghost
Copy link

ghost commented Jul 17, 2023

Description

@spylogsster
I found I found there is an issue seeing the individual cookies (from brave/brave-core#17746 - Added back Chromium implementation of views to look for individual cookies stored per-website) in Brave brave://settings/content/all for many domains where subdomains exist or where domains storages are done in www.example.com vs youtube.com like Youtube, where cookies are stored in youtube.com and the other storages are stored in www.youtube.com

Take a look at this screenshot:
image

As you can see there is no > right arrow in youtube.com, because it was replaced by the up and down arrow to expand and collapse domains, and only in www.youtube.com

and since there is no arrow to go to youtube.com and only to expand per 'subdomains', permissions or Cookies and Site Data button, can't be accessed unless the URL is manually changed to remove the www. part of it: brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.youtube.com%2F to brave://settings/content/siteDetails?site=https%3A%2F%2Fyoutube.com%2F

Once done that, then the Cookies and Site Data button will go to the correct place.
image

For example, this is what you get when you go to www.youtube.com one.
image, so it doesn't include the cookies since they were added in the youtube.com one, and for Browser's logic, they are different things, even the permissions are set differently, because one will be seen as domain and the other as subdomain I assume?

Anyway, I tested in a complete new User Data to avoid any issues with flags and anything else and same behavior, I also tested in Stable version and same issue where Expanding/Collapse arrow will replace it.

I must admit I rarely use this feature, but today I was testing Youtube and I saw I had to manually edit the URL to get the cookies, so not a big deal for me, but Brave team might want to fix the issue since it can mess with many domains, like live.com is another example, where you can't really access the live.com information, so you don't get to see all the cookies 32 cookies Brave says it has, and you can only access 24.

image

Missing all these 8 cookies, only because live.com can't be accessed once a subdomain takes place.

image

Thank you and have a good day.

Steps to Reproduce

  1. Go to youtube
  2. then go to brave://settings/content/all
  3. only www.youtube.com data can be accessed and not youtube.com

Brave version (brave://version info)

1.58.21 Chromium: 115.0.5790.75 (Official Build) nightly (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@ghost ghost added the OS/Desktop label Jul 17, 2023
@spylogsster
Copy link

cc @rebron

@rebron rebron added feature/cookies feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Jul 18, 2023
@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Jul 20, 2023

Yeah, it looks like we don't show the cookies set for the top-level Domain. The cookies that we show in brave://settings/content/all are organized by their Domain. In the example in the issue description, you can see the cookies in dev console if you go to youtube.com; they have their Domain set to be .youtube.com. We should show these under youtube.com. Right now we omit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/cookies feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
Status: P4 backlog
Development

No branches or pull requests

3 participants