Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added back Chromium implementation of views to look for individual cookies stored per-website. #17746

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Added back Chromium implementation of views to look for individual cookies stored per-website. #17746

merged 2 commits into from
Apr 10, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 24, 2023 •
edited
Loading

Resolves brave/brave-browser#27150

Added back Chromium implementation of views to look for individual cookies stored per-website.

cookies.mp4

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Go to brave://settings/cookies/detail?site=[domain] and check cookies for this site can be reviewd and deleted
  • Check cookies editing page can be navigated from brave://settings/content/siteDetails by clicking to Cookies and Site Data link

@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Mar 24, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster force-pushed the brave-27150 branch 2 times, most recently from 1a26349 to 80a9aa4 Compare March 27, 2023 11:51
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster force-pushed the brave-27150 branch 3 times, most recently from 5d1ad3e to 0ec03b1 Compare March 27, 2023 13:59
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster requested a review from petemill March 27, 2023 15:47
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster changed the title wip: Added cookies management page Added cookies management page Mar 28, 2023
@spylogsster spylogsster marked this pull request as ready for review March 28, 2023 11:47
@spylogsster spylogsster requested review from a team as code owners March 28, 2023 11:47
@spylogsster spylogsster changed the title Added cookies management page Added back Chromium implementation of views to look for individual cookies stored per-website. Mar 28, 2023
@spylogsster spylogsster requested a review from bsclifton March 28, 2023 12:30
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster requested a review from petemill April 3, 2023 18:36
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

iefremov
iefremov approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patches LGTM

petemill
petemill approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster merged commit cb17560 into master Apr 10, 2023
@spylogsster spylogsster deleted the brave-27150 branch April 10, 2023 14:52
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 10, 2023
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Apr 26, 2023
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request May 16, 2023
Closed
@ghost ghost mentioned this pull request Jul 17, 2023
Open
cdesouza-chromium
cdesouza-chromium reviewed Sep 26, 2023
View reviewed changes
browser/ui/webui/settings/settings_cookies_view_handler_unittest.cc

// Ref pointers to storage helpers used in the tree model used for testing.
// Retained to allow control over batch update completion.
scoped_refptr<browsing_data::MockLocalStorageHelper>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These variables are not named according to convention required by the the style guide [1]. I'm flagging this to raise some awareness, to authors and reviewers, as I've come across a few places today where such cases seemed to have got into master.

[1] https://google.github.io/styleguide/cppguide.html#Variable_Names

@emerick emerick mentioned this pull request Jun 25, 2024
Closed
6 tasks
@tlongfellow
Copy link

tlongfellow commented Sep 10, 2024 •
edited
Loading

The cookie page has again been removed. Clearly, Brave developers do not want users to have control over individual cookies - why? One reply is that users can navigate to an offending webpage and click the lock icon and deal with cookies that way. HOWEVER (shouting), this is NOT a viable choice for companies such as doubleclick who make their money by distributing ad cookies all over the place, and there are hundreds of companies like doubleclick. Brave developers are completely ignoring the fact that many of us want to see the cookies already accepted by the Brave browser so that we can build effective domain block lists. PUT THE COOKIE PAGE BACK, PLEASE!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdesouza-chromium cdesouza-chromium cdesouza-chromium left review comments

@petemill petemill petemill approved these changes

@iefremov iefremov iefremov approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@spylogsster spylogsster

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging this pull request may close these issues.

Add ability to view and manage individual cookies stored per-website in brave://settings
8 participants
@spylogsster @brave-builds @tlongfellow @petemill @iefremov @cdesouza-chromium @fmarier @thypon