Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 116 to Chromium 117. #31768

Closed
Tracked by #32053
mkarolin opened this issue Jul 20, 2023 · 5 comments · Fixed by brave/brave-core#19398
Closed
Tracked by #32053

Upgrade from Chromium 116 to Chromium 117. #31768

mkarolin opened this issue Jul 20, 2023 · 5 comments · Fixed by brave/brave-core#19398

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jul 20, 2023

Upgrade from Chromium 116 to Chromium 117

https://chromium.googlesource.com/chromium/src/+log/116.0.5845.163..117.0.5938.35/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Private/Tor/Guest windows have correct colors
  • Autocomplete in URL bar generally works as expected
  • Tab strip has expected colors and geometry
  • Browsing data removal generally works
  • Page Info UI generally works (cookies subpage specifically)
  • Tab search looks and functions as expected
  • Extensions can be installed
  • Shields generally work correctly (cookies blocked)
  • HTTP -> HTTPS upgrading works as expected
  • Vertical tabs look and work as expected
  • Password manager has expected Brave styling
  • Extensions WebUI has expected Brave styling

iOS Affected areas:
TBD

Android Affected areas:

  • Android 14 (we need extensive check since we may have incompatibility with third party libs (features to double check: VPN (when new billing API is merged Update billing dependency and update VPN code brave-core#19576), Playlist, Install Referrer, Safe Browsing))
  • Sync (double check it generally works)
  • Import/export bookmarks (check that it works)
  • Check that Only open links in current tab group from Appearance option works
@stephendonner
Copy link

stephendonner commented Sep 6, 2023

Verification PASSED using

Brave | 1.60.1 Chromium: 117.0.5938.35 (Official Build) nightly (64-bit)
-- | --
Revision | d50ecb0e74c51a1b522750008a9de6e61e8dabc8
OS | Windows 10 Version 22H2 (Build 19045.3393)

Desktop affected areas

Private/Tor/Guest windows have correct colors - PASSED

Confirmed Brave color schemes for:

  • normal {Dark, Light}
  • Private
  • Tor
  • Guest windows
Normal, Light Normal, Dark Private Tor Guest
image image image image image

Autocomplete in URL bar generally works as expected - PASSED

Confirmed autocomplete against:

  • Top sites
  • Browsing history
  • Bookmarks with default options
brave://settings/appearance top sites browsing history bookmarks
image image image image

Confirmed autocomplete provided search suggestions when Improve search suggestions is set to Enabled / On

brave://settings/search improve search suggestions
image image

Tab strip has expected colors and geometry - PASSED

Horizontal

1.57.62 1.60.3
image image

Vertical

1.57.62 1.60.3
image (2) image

Browsing data removal generally works - PASSED

Basic - PASSED

Clear browsing data dialog Browsing history Cookies and other site data Cached images and files
image image image N/A

Advanced - PASSED

Clear browsing data dialog Browsing history Cookies and other site data Download history Passwords
image image image image image

On exit - PASSED

Clear browsing data dialog Browsing history Download history Cookies and other site data
image image image image

Page Info UI generally works (cookies subpage specifically) - PASSED

Confirmed ability to view and manage cookies via the page-info dialog's submenus

Manage cookies and site data Cookies and site data cleared data reload prompt logged out
image image image image image

Tab search looks and functions as expected - PASSED

Confirmed:

  • default view
  • type-down search
  • recently-closed view
  • setting Show tab search button to Off / Disabled removes the ^ from the browser toolbar
  • ctrl + shift + A shortcut still invokes the above
default view "news" type-down search recently closed ctrl + shift + A
image image image image

Encountered:

Shields generally work correctly (cookies blocked) - PASSED

Block all cookies - PASSED

example example
image (4) image (5)

Block cross-site cookies - PASSED

example example
image image (1)

Allow all cookies - PASSED

example example
image image

HTTP -> HTTPS upgrading works as expected - PASSED

Confirmed:

  • automatic upgrade from http://upgradable.arthuredelstein.net to https://upgradable.arthuredelstein.net worked
  • got warning interstitial on https://insecure.arthuredelstein.net
  • could click through the above warning, to fully load https://insecure.arthuredelstein.net
  • Not secure warning icon in address bar for http://http.badssl.com
http://upgradable.arthuredelstein.net https://insecure.arthuredelstein.net clicked through http.badssl.com
image image image image

Vertical tabs look and work as expected - PASSED

Confirmed:

  • default (horizontal) tab mode
  • Use vertical tabs context-menu item
  • vertical-tabs mode
  • collapsed mode/expand-on-hover pref
  • drag & drop of vertical tabs
  • tab groups
default tab view vertical tabs enabled collapsed tabs tab groups
image image image image

Password manager has expected Brave styling - PASSED

Confirmed Brave styling for both Dark and Light modes

example example example example
image image image image

Encountered:

Extensions WebUI has expected Brave styling & Extensions can be installed - PASSED

Confirmed:

  • Brave styling
  • Light and Dark theme support
  • installing, disabling, and removing extensions
example example example example example example
image image image image image image

Settings comparison - PASSED

Brave | 1.60.3 Chromium: 117.0.5938.35 (Official Build) nightly (64-bit)
-- | --
Revision | 6f3491e9658c636314365097686bdbd636d39163
OS | Windows 10 Version 22H2 (Build 19045.3393)
  • Get started - no changes
  • Appearance - no changes
  • New Tab Page - no changes
  • Shields - no changes
  • Brave Rewards - no changes
  • Social media blocking
  • removed Allow use of third-party cookies for legacy Google Sign-in
1.57.62 1.60.3
image image
  • Privacy and security
  • added new Go Off-The-Record when visiting sensitive sites pref, defaulted to Ask
1.57.62 1.60.3
image image
  • Sync - no changes
  • Search engine - no changes
  • Extensions - no changes
  • Web3
  • removed Redirect IPFS resources to the configured IPFS gateway
1.57.62 1.60.3
image image
  • Leo
  • new section added
1.57.62 1.60.3
image image
  • Autofill and passwords
  • added new brave://password-manager/passwords view
  • also added new Allow auto-fill in private windows pref
1.57.62 1.60.3
image image
1.57.62 1.60.3
image image

Languages - no changes
Downloads - no changes
Help tips - no changes
System

  • added new Brave VPN Use WireGuard protocol in Brave VPN pref
1.57.62 1.60.3
image image

Reset settings - no changes


Encountered:

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 7, 2023

Verified on Samsung Galaxy S21 using version

Brave	1.60.2 Chromium: 117.0.5938.35 (Official Build) canary (32-bit) 
Revision	b2219c437bef2f067d4b4ae477f167a77537f93e
OS	Android 13; Build/TP1A.220624.014; 33; REL

Sync

Tab Groups

  • Spot checked tab group functionality is working on new and existing profile.
  • Verified relaunch notification is deprecated in CR117 when changing toggle state.
Example Example
Screenshot 2023-09-07 at 5 30 37 PM Screenshot 2023-09-07 at 5 34 12 PM

Import/Export Bookmarks

  • Ensured import / export bookmarks is working as expected on new and existing profile.
Example Example
Screenshot 2023-09-07 at 5 38 13 PM Screenshot 2023-09-07 at 5 42 45 PM

@stephendonner stephendonner added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 8, 2023
@hffvld
Copy link
Contributor

hffvld commented Sep 8, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB5.230623.009 release-keys]
Brave build: 1.60.6
Chromium: 117.0.5938.48 (Official Build) canary (64-bit)
Revision: 3729c99b569a7aab570e3f55471c699556e539f9
VPN
Playlist
  • It's not available in the latest Nightly build and the flag is still disabled.
1
1
Safe browsing
  • Verified that Safe Browsing is enabled by default
  • Verified that opening links from https://testsafebrowsing.appspot.com/ are showing a warning when Safe browsing is ON, and not showing when OFF.
1 2 3
1 2 3
1 2 3
1 2 3
1 2 3

@hffvld
Copy link
Contributor

hffvld commented Sep 8, 2023

Hi @kjozwiak can you check Install Referrer on Android 14 when you have time?

@kjozwiak
Copy link
Member

kjozwiak commented Sep 11, 2023

Labelling as QA/No & release-notes/exclude in favour of #32809. Remaining work outlined via #32809 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment