Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 116 to Chromium 117 (uplift to 1.58.x). #20025

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Sep 6, 2023

Resolves brave/brave-browser#31768
Uplift from #19398

Uplift from #20022

Resolves brave/brave-browser#32816
Uplift from #20029

Resolves brave/brave-browser#32809
Uplift from #20030

Resolves brave/brave-browser#32840
Uplift from #20047

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Sep 6, 2023
@mkarolin mkarolin self-assigned this Sep 6, 2023
@mkarolin mkarolin requested a review from a team as a code owner September 6, 2023 21:13
@github-actions github-actions bot added potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Sep 6, 2023
mkarolin and others added 5 commits September 6, 2023 21:40
Upgrade from Chromium 116 to Chromium 117
This was done in the original cr117 PR, but this change is specific to
1.58.x branch rust sources.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/eed02145256f53a0e85ffbb5bac4d567b625862a

commit eed02145256f53a0e85ffbb5bac4d567b625862a
Author: danakj <[email protected]>
Date:   Wed Jul 19 14:59:28 2023 +0000

    List all inputs to rust targets in GN and verify them during build

    RBE requires all inputs to be named in order for it to copy them to
    the remote build environment.

    GN analyze requires all inputs to be named in order to decide what
    needs to be rebuilt based on a list of modified files. The current GN
    analyze setup was supposed to do this as well, but it is not working.

    Have gnrt produce a list of all (possible) input files for 3p and
    stdlib crates so that it can be included in the generated BUILD.gn
    files.

    Then verify in rustc_wrapper.py that all inputs rustc reports are
    found in the GN rule's sources or inputs fields by comparing with the
    depfile produced from rustc.

    Bug: 1459444
[iOS] Remove breaking `enable_arc` build configs
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

* Upgrade from Chromium 117.0.5938.35 to Chromium 117.0.5938.48

* Upgrade patches from Chromium 117.0.5938.35 to Chromium 117.0.5938.48

* Update pins list timestamp

* Updated strings for Chromium 117.0.5938.48

---------

Co-authored-by: brave-builds <[email protected]>
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

[iOS] - Fix #32840: Disable Chromium Session-Restore for WebState and WebViews
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak added this to the 1.58.x - Release milestone Sep 11, 2023
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.58.x approved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants