-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 116 to Chromium 117 (uplift to 1.58.x). #20025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
750b780
to
31cf313
Compare
Upgrade from Chromium 116 to Chromium 117
This was done in the original cr117 PR, but this change is specific to 1.58.x branch rust sources. Chromium change: https://chromium.googlesource.com/chromium/src/+/eed02145256f53a0e85ffbb5bac4d567b625862a commit eed02145256f53a0e85ffbb5bac4d567b625862a Author: danakj <[email protected]> Date: Wed Jul 19 14:59:28 2023 +0000 List all inputs to rust targets in GN and verify them during build RBE requires all inputs to be named in order for it to copy them to the remote build environment. GN analyze requires all inputs to be named in order to decide what needs to be rebuilt based on a list of modified files. The current GN analyze setup was supposed to do this as well, but it is not working. Have gnrt produce a list of all (possible) input files for 3p and stdlib crates so that it can be included in the generated BUILD.gn files. Then verify in rustc_wrapper.py that all inputs rustc reports are found in the GN rule's sources or inputs fields by comparing with the depfile produced from rustc. Bug: 1459444
[iOS] Remove breaking `enable_arc` build configs
Update cargo-audit to v0.18.1
97e349a
to
dd8d88e
Compare
A Storybook has been deployed to preview UI for the latest push |
* Upgrade from Chromium 117.0.5938.35 to Chromium 117.0.5938.48 * Upgrade patches from Chromium 117.0.5938.35 to Chromium 117.0.5938.48 * Update pins list timestamp * Updated strings for Chromium 117.0.5938.48 --------- Co-authored-by: brave-builds <[email protected]>
A Storybook has been deployed to preview UI for the latest push |
[iOS] - Fix #32840: Disable Chromium Session-Restore for WebState and WebViews
A Storybook has been deployed to preview UI for the latest push |
kjozwiak
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 1.58.x
approved 👍
This was referenced Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/run-audit-deps
Check for known npm/cargo vulnerabilities (audit_deps)
CI/run-network-audit
Run network-audit
CI/run-upstream-tests
Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
CI/storybook-url
Deploy storybook and provide a unique URL for each build
feature/web3/wallet/core
feature/web3/wallet
potential-layer-violation-fixes
This PR touches a BUILD.gn file with check_includes=false
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#31768
Uplift from #19398
Uplift from #20022
Resolves brave/brave-browser#32816
Uplift from #20029
Resolves brave/brave-browser#32809
Uplift from #20030
Resolves brave/brave-browser#32840
Uplift from #20047
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: