Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme backgrounds not correctly displayed on tabstrip #36392

Closed
zenparsing opened this issue Feb 27, 2024 · 3 comments · Fixed by brave/brave-core#22337
Closed

Theme backgrounds not correctly displayed on tabstrip #36392

zenparsing opened this issue Feb 27, 2024 · 3 comments · Fixed by brave/brave-core#22337
Assignees
Labels
feature/tabs-bar OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include

Comments

@zenparsing
Copy link

Description

In some themes, the background of the tabstrip in horizontal mode is not painted correctly. For some themes, the background is only incorrect when the browser does not have focus.

Steps to Reproduce

Actual result:

Screenshot 2024-02-27 at 10 34 35 AM Screenshot 2024-02-27 at 10 34 51 AM

Expected result:

Screenshot 2024-02-27 at 10 23 36 AM Screenshot 2024-02-27 at 10 24 12 AM

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.63.161 Chromium: 122.0.6261.57 (Official Build) (x86_64)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2024

The above requires 1.63.167 or higher for 1.63.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 5, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Mar 5, 2024

Verified with

Brave | 1.63.168 Chromium: 122.0.6261.94 (Official Build) (x86_64)
-- | --
Revision | 08196d502fa95681adc6dd9fc06a04d0664ac538
OS | macOS Version 13.6.4 (Build 22G513)

Reproduced the issue using above themes and 1.63.165 Chromium: 122.0.6261.94:

Example Example
Screenshot 2024-03-05 at 10 03 16 AM Screenshot 2024-03-05 at 10 03 27 AM

Using the STR/Cases outlined via #36392 (comment), ensured that the themes are being applied/displayed correctly as per the following when using 1.63.168 Chromium: 122.0.6261.94:

Example Example Example
1 2 3

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 5, 2024
@Dean-Corso
Copy link

Hey guys,

depending on the set custom themes by users it brings again the big question up when you dev guys finally allow (again) to use our chosen theme in all three browser running states (Normal - Private - Tor)? I don't know how often I should ask about it and it really makes me upset because there are many user out there who want to get that feature back to use one custom theme for all. Just have a look below...
Theme_2024-03-07_220000
...and my custom theme I did choose in this example image is the first one on top and in Private & Tor state I get your ugly colored themes presented I don't wanna have there. So whats the point with those "MUST USE THEMES"? Is it so damn important for you guys to press your color rubber stamp on us? Or do you think it's some kind of COOL? Its not of course and its just damn stupid to force us to live with those ugly colored MUST USE themes! Just let us users decide what themes we wanna use like in earlier days where it was possible and stop forcing us. I thought after long time of complaining about that you guys would became more adult but somehow I was wrong and you are still same like before, right. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/tabs-bar OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants