Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect brave icons colors in top toolbar on tab view transition #36438

Closed
samartnik opened this issue Feb 28, 2024 · 1 comment · Fixed by brave/brave-core#22378
Closed

Comments

@samartnik
Copy link
Contributor

samartnik commented Feb 28, 2024

Description

screen-20240228-110322.mp4

Steps to reproduce

  1. In light mode go to any dark web site (like reddit.com)
  2. While it's being loaded go to tab view
  3. In transition background of our icons will be still light for a while until eventually we get proper color

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Feb 28, 2024
@samartnik samartnik self-assigned this Feb 28, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 28, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 1, 2024
@hffvld
Copy link
Contributor

hffvld commented Apr 1, 2024

Verified on Pixel 2 XL, Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Pixel 2 XL / taimen-user  8.1.0 OPM2.171026.006.H1 release-keys
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 14 AP21.240216.010 release-keys
Brave build: 1.65.96 
Chromium: 123.0.6312.86 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the steps from Fix incorrect brave icons colors in top toolbar on tab view transition #36438 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the icons on the transition screen have the correct color

Pixel 2 XL

2024-04-01_16-26-43.mp4

Galaxy Tab S8

2024-04-01_16-11-02.mp4

Pixel 7

2024-04-01_16-06-11.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants