Using cached ad-block results after changing shield settings

[cuba]

Description:

When changing from aggressive to standard (or vice versa), we use the cached values of the previous setting resulting in no change in behaviour in some cases when switching settings

NOTE: This issue will mess with the behaviour in the STR so make sure it is merged first #37084

Steps to Reproduce

1. Load a blocked page such as https://wallet-api.urbanairship.com
2. Notice the blocked page comes up
3. Switch modes (i.e. from standard to aggressive or aggressive to standard)
4. Reload the page (note: you have to click on the url bar and enter the address or else you are refreshing the interstitial page and no change will occur)

Actual result:

No change of behaviour between standard and aggressive mode

Expected result:

Change of behaviour between standard and aggressive mode

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

• Can you reproduce this issue with the most recent build from TestFlight?
• Can you reproduce this issue with the previous version of the current build from TestFlight?
• Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

[hffvld]

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.5
Brave build: 1.66 (95)
BraveCore: 1.66.95 (124.0.6367.91)

---

STEPS:

1. Follow the steps from Using cached ad-block results after changing shield settings #37090 (comment)
2. Verify

ACTUAL RESULTS:

• Verified that Trackers & Ads Blocking settings applied on a blocked page without Brave restart

---

Reproduced

2024-04-30_12-34-14.mp4

Verified

2024-04-30_12-37-52.mp4