Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update twitter.com to x.com #39322

Closed
5 tasks
anthonypkeane opened this issue Jun 24, 2024 · 1 comment · Fixed by brave/brave-core#24495
Closed
5 tasks

Update twitter.com to x.com #39322

anthonypkeane opened this issue Jun 24, 2024 · 1 comment · Fixed by brave/brave-core#24495
Assignees
@iccub
Labels
feature/new-tab OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@anthonypkeane
Copy link

Description

On the NTP we have a few favourites, one being Twitter. Please update the URL for this from twitter.com to x.com

https://appfigures.com/reviews/42132121512LsnWwdAgI_b9CXt2rKNXHSA?lang=en

Steps to reproduce

  3. NA

Actual result

NA

Expected result

NA

Reproduces how often

Easily reproduced

Brave version

NA

Device/iOS version

NA

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@anthonypkeane anthonypkeane added the OS/iOS Fixes related to iOS browser functionality label Jun 24, 2024
@iccub iccub self-assigned this Jul 3, 2024
@iccub iccub added the QA/Yes label Jul 3, 2024
iccub added a commit to brave/brave-core that referenced this issue Jul 3, 2024
@iccub
[iOS] Rename Twitter to X.
d4933a9 
Resolves brave/brave-browser#39322
@iccub iccub mentioned this issue Jul 3, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 5, 2024
iccub added a commit to brave/brave-core that referenced this issue Jul 5, 2024
@iccub
[iOS] Rename Twitter to X. (#24495)
ba1e9b1 
Resolves brave/brave-browser#39322
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 17.5.1 using version 1.69 (136)

  • Ensured that twitter favorite is renamed to X for new users on NTP.
  • Ensured that twitter favorite remains when upgrading app.
  • Ensured that icon matches https://x.com/
  • Ensured that tapping on the favorite will open https://x.com
1.68 1.69 x.com
IMG_6926 IMG_6927 IMG_6928

@kjozwiak kjozwiak mentioned this issue Sep 4, 2024
Closed
14 tasks
@Uni-verse Uni-verse mentioned this issue Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iccub iccub

Labels
feature/new-tab OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] Rename Twitter to X. brave/brave-core
5 participants
@kjozwiak @iccub @anthonypkeane @Uni-verse @brave-builds