Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus sign button in tab bar is cut off [iPad] #40500

Closed
2 of 5 tasks
Uni-verse opened this issue Aug 16, 2024 · 3 comments · Fixed by brave/brave-core#25481
Closed
2 of 5 tasks

Plus sign button in tab bar is cut off [iPad] #40500

Uni-verse opened this issue Aug 16, 2024 · 3 comments · Fixed by brave/brave-core#25481
Assignees
Labels
bug feature/user-interface All UI related iPad-specific OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPad QA/Yes regression release-notes/exclude

Comments

@Uni-verse
Copy link
Contributor

Description

+ button in tab bar is cut off as of 1.69, same on Nightly

Steps to reproduce

  1. New install
  2. Observe tab bar on NTP

Actual result

1.69.x

IMG_1544

Expected result

1.68.x

IMG_1545

Reproduces how often

Easily reproduced

Brave version

1.69 (147) - Reproducible
1.70 (77) - Reproducible

Device/iOS version

iPad( 7th Gen ) | iPadOS 17.5.1

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@Uni-verse Uni-verse added bug feature/user-interface All UI related priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude OS/iOS Fixes related to iOS browser functionality iPad-specific labels Aug 16, 2024
@Uni-verse Uni-verse changed the title Plus sign button in tab bar is cut off Plus sign button in tab bar is cut off [iPad] Aug 16, 2024
@Brandon-T Brandon-T self-assigned this Aug 16, 2024
@Brandon-T
Copy link

Brandon-T commented Sep 7, 2024

This is broken due to this PR: #38789 which changed the images but didn't verify it :(

@kjozwiak
Copy link
Member

The above requires 1.69.168 or higher for 1.69.x verification 👍

@hffvld
Copy link
Contributor

hffvld commented Sep 11, 2024

Verified on iPad Air using version(s):

Device/OS: iPad Air / iPadOS 16.7.2
Brave build: 1.69 (168)
BraveCore: 1.69.168 (128.0.6613.138)

STEPS:

  1. Follow the STR/TP from Plus sign button in tab bar is cut off [iPad] #40500 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that + button is shown properly and not cut off.
  • Verified that all actions tapping on + button wrorks as expected.

1 2 3 4
1 2 3 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/user-interface All UI related iPad-specific OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPad QA/Yes regression release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants