Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://www.photopea.com/ ads showing in shields #40619

Closed
3 of 6 tasks
ryanbr opened this issue Aug 22, 2024 · 8 comments
Closed
3 of 6 tasks

https://www.photopea.com/ ads showing in shields #40619

ryanbr opened this issue Aug 22, 2024 · 8 comments
Assignees
Labels
closed/fixed-by-component-update feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@ryanbr
Copy link

ryanbr commented Aug 22, 2024

Description

Opening https://www.photopea.com/

Steps to reproduce

  1. Opening https://www.photopea.com/
  2. wait 5-20secs.
  3. ads and a antii-adblock popup

Actual result

photopeeas

Expected result

photopeeas2

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.69

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

||pagead2.googlesyndication.com^$xhr,3p,redirect-rule=noop.js,method=head,from=photopea.com related rule

@ryanbr ryanbr added priority/P4 Planned work. We expect to get to it "soon". OS/Desktop labels Aug 22, 2024
ryanbr added a commit to brave/adblock-lists that referenced this issue Aug 22, 2024
ryanbr added a commit to brave/adblock-lists that referenced this issue Aug 22, 2024
@Arthurprnt
Copy link

Hello,
By removing ads, some features of the website are broken.
For exemple: photopea/photopea#7108

@kuckir
Copy link

kuckir commented Aug 28, 2024

Hi guys, I am the creator of Photopea. I had to use a different Github account, since you have blocked my official account https://github.com/photopea/

In your last release of Brave, you completely break Photopea. Why do you do it?

photopea/photopea#7085
photopea/photopea#7087
photopea/photopea#7089
photopea/photopea#7090
photopea/photopea#7094
photopea/photopea#7094
photopea/photopea#7100
photopea/photopea#7101
photopea/photopea#7108
photopea/photopea#7109

I hope you are happy to cause your users so much pain. And it is painful for me to have to tell everyone to switch to a different browser.

If you dont fix it in 2 days, Photopea.com in Brave will be just a white screen saying "Switch to a better web browser."

@bsclifton
Copy link
Member

Hi @kuckir

I assure you, it's not the intention to break Photopea. This is my first time hearing about the website

Thanks for sharing the specific issues - I'll see if we can help with a webcompat fix. I can confirm the official account is blocked - but I don't see why at the moment. I suspect there may have been some heated messages which other repository owners ended up deleting. I can definitely unblock this account if we're able to keep a good relationship here

Let me share this issue - stay tuned

@ShivanKaul
Copy link
Collaborator

@kuckir were you able to repro the breakage? Similar to you, I'm having issues reproducing the issue on Brave: photopea/photopea#7090 (comment)

I've created #40735 to track this breakage. We want to get to the bottom of this and figure out what aspect of our blocking is breaking photopea.com.

@kuckir
Copy link

kuckir commented Aug 28, 2024

I do allow my users to block ads in Photopea.

But I want to tell them, that my income depends on them watching ads, or paying for a Premium account, and ask them to watch ads.

If you will try to remove my message "Are you blocking ads?", I will detect it and I will not allow a user to use any part of my work in such a case.

@ryanbr
Copy link
Author

ryanbr commented Aug 28, 2024

Its been fixed.

@ShivanKaul
Copy link
Collaborator

Closing this out since the original issue opened by @ryanbr is fixed and the website breakage also seems to be fixed. Tracking adblock-rust support for the filter mentioned in the issue description here: brave/adblock-rust#391

@ShivanKaul
Copy link
Collaborator

(Just a reminder about Brave's blocking goals and policy: https://github.com/brave/brave-browser/wiki/Blocking-goals-and-policy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/fixed-by-component-update feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

6 participants