Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Playlist Crash #41232

Closed
3 of 5 tasks
Brandon-T opened this issue Sep 24, 2024 · 2 comments · Fixed by brave/brave-core#25706
Closed
3 of 5 tasks

[iOS] - Playlist Crash #41232

Brandon-T opened this issue Sep 24, 2024 · 2 comments · Fixed by brave/brave-core#25706
Assignees
@Brandon-T
Labels
crash features/playlist OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.71.x - Release #2

Comments

@Brandon-T
Copy link

Description

Playlist sometimes crashes deleting offline data

Steps to reproduce

  1. Delete offline playlist data

Actual result

  • Crash

Expected result

  • Shouldn't Crash

Reproduces how often

Easily reproduced

Brave version

1.68.x

Device/iOS version

Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@Brandon-T Brandon-T added the OS/iOS Fixes related to iOS browser functionality label Sep 24, 2024
@Brandon-T Brandon-T self-assigned this Sep 24, 2024
@Brandon-T Brandon-T mentioned this issue Sep 24, 2024
Merged
24 tasks
@kylehickinson kylehickinson mentioned this issue Sep 25, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.72.x - Nightly milestone Oct 7, 2024
@brave-builds brave-builds mentioned this issue Oct 17, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.71.116 or higher for 1.71.x verification 👍

@kjozwiak kjozwiak mentioned this issue Oct 23, 2024
Closed
17 tasks
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 24, 2024
@hffvld
Copy link
Contributor

hffvld commented Oct 24, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7
Brave build: 1.71 (118)
BraveCore: 1.71.118 (130.0.6723.70)

STEPS:

  1. Follow the STR/TP from [iOS] - Playlist Crash #41232 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that Brave does not crash when removing offline Playlist items.
2024-10-24_13-06-49.mp4

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 24, 2024
@Uni-verse Uni-verse mentioned this issue Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
crash features/playlist OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.71.x - Release #2
Development

Successfully merging a pull request may close this issue.

[iOS] - Fix Playlist Crash Deleting Offline Data brave/brave-core
4 participants
@Brandon-T @kjozwiak @brave-builds @hffvld