Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve toolbar icon sizing/balance #41405

Closed
kylehickinson opened this issue Oct 4, 2024 · 2 comments · Fixed by brave/brave-core#25814
Closed

Improve toolbar icon sizing/balance #41405

kylehickinson opened this issue Oct 4, 2024 · 2 comments · Fixed by brave/brave-core#25814
Assignees
@kylehickinson
Labels
OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.73.x - Release

Comments

@kylehickinson
Copy link
Collaborator

Description

The icon sizing for the shortcut button was a bit large which has led to some discussion about rebalancing the icon sizes in the toolbar in general.

New expected changes:
image

  • Bottom toolbar icons when toolbars are split will stay their larger sizes
  • Icons that show up in toolbar along with the URL bar will now be smaller
  • Icons are now smaller when the unified toolbar is used
@kylehickinson kylehickinson added the OS/iOS Fixes related to iOS browser functionality label Oct 4, 2024
@kylehickinson kylehickinson self-assigned this Oct 4, 2024
@kylehickinson kylehickinson mentioned this issue Oct 4, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.72.x - Nightly milestone Oct 4, 2024
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 14, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 14, 2024 •
edited
Loading

Verified on iPhone 12 running iOS 18.0 using version 1.73 (89)

Verified the following based on acceptance criteria in #41405 (comment)

  • Bottom toolbar icons when toolbars are split will stay their larger sizes.
  • Icons that show up in toolbar along with the URL bar will now be smaller.
  • Icons are now smaller when the unified toolbar is used.

Portrait - 1.71 Top, 1.73 Bottom

Playlist icon Reader Mode icon Wallet icon
Image Image Image
Image Image Image

Landscape - Playlist Icon

1.71.x
Image
1.73.x
Image

Landscape - Reader mode icon

1.71.x
Image
1.73.x
Image

Landscape - Wallet icon

1.71.x
Image
1.73.x
Image

@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 15, 2024 •
edited
Loading

Verified on iPad (7th Gen) running iOS 17.5.1 using version 1.73 (89)

Verified the following based on acceptance criteria in #41405 (comment)

  • Bottom toolbar icons when toolbars are split will stay their larger sizes.
  • Icons that show up in toolbar along with the URL bar will now be smaller.
  • Icons are now smaller when the unified toolbar is used.

Landscape - Unified bar

1.71.x
Image
1.73.x
Image

Split View - Landscape Split View - Portrait
Image Image
Slide Over - Landscape Slide Over - Portrait
Image Image

@Uni-verse Uni-verse added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 15, 2024
@kjozwiak kjozwiak mentioned this issue Nov 18, 2024
Closed
20 tasks
@Uni-verse Uni-verse mentioned this issue Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
OS/iOS Fixes related to iOS browser functionality QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] Improve toolbar icon sizing brave/brave-core
3 participants
@kylehickinson @Uni-verse @brave-builds