Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shred button displayed unnecessarily on certain screens #41671

Closed
2 of 5 tasks
Uni-verse opened this issue Oct 16, 2024 · 2 comments · Fixed by brave/brave-core#26049
Closed
2 of 5 tasks

Shred button displayed unnecessarily on certain screens #41671

Uni-verse opened this issue Oct 16, 2024 · 2 comments · Fixed by brave/brave-core#26049
Assignees
@StephenHeaps
Labels
OS/iOS Fixes related to iOS browser functionality privacy/shred-feature Issues related to the Shred feature QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.71.x - Release #2

Comments

@Uni-verse
Copy link
Contributor

Description

Shred button displayed unnecessarily on certain screens

These include:

  • Private Browsing opt in page
  • Synced tabs from other devices screen
Private tab Tabs from other devices
Image Image

Steps to reproduce

  1. New install
  2. Switch tabs to Private
  3. In normal tab mode, switch to "Tabs from other devices" after connecting to Sync chain (enable Sync tabs)

Actual result

  • Shred button is shown on Private tab screen which is unnecessary because there is nothing to shred
  • Shred button is shown on "Tabs from other devices" screen in tab view. Also unnecessary because shred button only affects tabs opened locally.

Expected result

Remove from these screens

Reproduces how often

Easily reproduced

Brave version

1.71 (112)

Device/iOS version

iPhone, iOS 18.0

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@Uni-verse Uni-verse added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/iOS Fixes related to iOS browser functionality privacy/shred-feature Issues related to the Shred feature QA/Yes release-notes/exclude labels Oct 16, 2024
@StephenHeaps StephenHeaps self-assigned this Oct 16, 2024
@StephenHeaps StephenHeaps mentioned this issue Oct 16, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 18, 2024
This was referenced Oct 18, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.71.117 or higher for 1.71.x verification 👍

@kjozwiak kjozwiak mentioned this issue Oct 23, 2024
Closed
17 tasks
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 24, 2024
@Uni-verse
Copy link
Contributor Author

Verified on iPhone 12 running iOS 18 using version 1.71.118

  • Ensured that Shred button is not displayed on private tab screen (no tabs)
  • Ensured that Shred button is not displayed on Tabs from Other Devices screen.
example example example
Image Image Image
Image Image Image

@Uni-verse Uni-verse added QA Pass - iPhone and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenHeaps StephenHeaps

Labels
OS/iOS Fixes related to iOS browser functionality privacy/shred-feature Issues related to the Shred feature QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.71.x - Release #2
Development

Successfully merging a pull request may close this issue.

fix(privacy): Fix shred button visibility brave/brave-core
4 participants
@kjozwiak @StephenHeaps @Uni-verse @brave-builds