Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(privacy): Fix shred button visibility #26049

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

StephenHeaps
Copy link
Collaborator

@StephenHeaps StephenHeaps commented Oct 16, 2024

  • Hide shred button when showing 0 tabs in private mode
  • Hide shred button when showing tabs from other devices

Resolves brave/brave-browser#41671

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable Shred feature flag (#brave-shred) in brave://flags, quit Brave from app switcher & relaunch Brave.
  2. In 'Settings' -> 'Sync', setup sync if not setup and enable 'Open Tabs' under 'Sync Settings'.
  3. Verify Shred button is visible when in tab tray in regular mode.
  4. Verify Shred button is hidden when viewing 'Tabs from other devices' in tab tray.
    • When syncing Open Tabs, open tab tray and switch to this view in regular mode via the top control
  5. Verify Shred button is hidden when in tab tray in private mode with 0 tabs
  6. Verify Shred button is visible when in tab tray in private mode with 1+ tabs

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Oct 16, 2024
@StephenHeaps StephenHeaps self-assigned this Oct 16, 2024
@StephenHeaps StephenHeaps marked this pull request as ready for review October 17, 2024 04:30
@StephenHeaps StephenHeaps requested a review from a team as a code owner October 17, 2024 04:30
@StephenHeaps StephenHeaps merged commit a9fb670 into master Oct 18, 2024
18 checks passed
@StephenHeaps StephenHeaps deleted the bugfix/privacy-shred-button branch October 18, 2024 13:44
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 18, 2024
brave-builds added a commit that referenced this pull request Oct 18, 2024
brave-builds added a commit that referenced this pull request Oct 18, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.26

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 21, 2024

Verified on iPhone 12 running iOS 18.0 using version 1.72 (30)

Case 1: Private mode (no tabs)

  • Ensured that Shred button does not show up in Private mode with 0 tabs.
  • Ensured that Shred button is working in private and normal tab modes and switching between them does not cause issues.
  • Ensured that Shred button is shown correctly in normal tabs.
  • Ensured enabling some settings (Keep Private Tabs) to make sure Shred button is shown after relaunching browser in Private mode. (encountered - Crash on launch with shred feature and keep private tabs setting enabled brave-browser#41765)
example example example
IMG_7807 IMG_7808 IMG_7809

Case 2: Tabs from other devices (Sync)

  • Ensured that Shred button is not shown in the Tabs from other devices tab
  • Ensured that Shred button has not regressed in tab view.
example example
IMG_7811 IMG_7812

kjozwiak pushed a commit that referenced this pull request Oct 21, 2024
kjozwiak pushed a commit that referenced this pull request Oct 21, 2024
@bsclifton bsclifton modified the milestones: 1.73.x - Nightly, 1.74.x - Nightly Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shred button displayed unnecessarily on certain screens
5 participants