Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shred intermittently not clearing all data #41897

Closed
2 of 5 tasks
StephenHeaps opened this issue Oct 25, 2024 · 2 comments · Fixed by brave/brave-core#26246
Closed
2 of 5 tasks

Shred intermittently not clearing all data #41897

StephenHeaps opened this issue Oct 25, 2024 · 2 comments · Fixed by brave/brave-core#26246
Assignees
Labels
bug OS/iOS Fixes related to iOS browser functionality privacy/shred-feature Issues related to the Shred feature privacy QA Pass - iPhone QA/Yes release-notes/exclude

Comments

@StephenHeaps
Copy link

StephenHeaps commented Oct 25, 2024

Description

Shred is not always removing all data when a site is Shred manually from an open tab

Steps to reproduce

  1. Enable Shred feature flags in brave://flags
  2. Open 'Settings' -> 'Shields & Privacy' -> 'Manage Website Data' and remove all data
  3. Visit amazon.com
  4. Shred the amazon.com tab
  5. Open 'Settings' -> 'Shields & Privacy' -> 'Manage Website Data'
    • Intermittent, so may have to repeat more than once to reproduce.

Actual result

amazon-shred.MP4

Expected result

All data is cleared from the site being Shred

Reproduces how often

Intermittent issue

Brave version

1.71+

Device/iOS version

Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

cc @hffvld

@kjozwiak
Copy link
Member

The above requires 1.71.122 or higher for 1.71.x verification 👍

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 4, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18 using version 1.71 (122)

Verified STR in #41897 (comment)

  • Ensured that Shredding tab will clear all website data for new and existing users (when both flags are enabled).
  • Ensured that Shredding works through tab icon / Shields panel.
  • Ensured that website data is cleared from History page.
example example example example example
Image Image Image Image Image

@Uni-verse Uni-verse added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/iOS Fixes related to iOS browser functionality privacy/shred-feature Issues related to the Shred feature privacy QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants