Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3rd-party cookie blocking causing website faults #4770

Closed
ryanbr opened this issue Jun 10, 2019 · 7 comments
Closed

3rd-party cookie blocking causing website faults #4770

ryanbr opened this issue Jun 10, 2019 · 7 comments
Labels
closed/duplicate Issue has already been reported feature/shields/cookies Cookie controls implemented as part of Shields. priority/P4 Planned work. We expect to get to it "soon". webcompat/shields Shields is breaking a website.

Comments

@ryanbr
Copy link

ryanbr commented Jun 10, 2019

Description

When debuging this https://twitter.com/johnnyryan/status/1137967756148649984 Noticed that the slideshow will only work if allcookies are allowed.

If enabling 3rd party cookie blocking, it'll prevent slideshare.net from working.

The options in firefox (nightly), has an option to block all 3rd-party cookies. the slideshow works fine here.

Steps to Reproduce

  1. Enable Sheilds, with 3rd party cookie blocking.
  2. Visit https://twitter.com/johnnyryan/status/1137967756148649984
  3. Slideshow should still work.
  4. Repeat same task if need be in Firefox nightly, with 3rd-party cookies blocking enabled.
  5. Works fine in Firefox

Actual result:

Slideshow navigation being blocked.

Expected result:

Slideshow navigation shouldn't be blocked

Reproduces how often:

Occurs in Brave Nightly, and Release.

Brave version (brave://version info)

Tested in Nightly; Version 0.68.26 Chromium: 75.0.3770.80 (Official Build) nightly (64-bit)
Release: Version 0.65.118 Chromium: 75.0.3770.80 (Official Build) (64-bit)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    Yes
  • Does the issue resolve itself when disabling Brave Rewards?
    Have not checked, probably not an issue.
  • Is the issue reproducible on the latest version of Chrome?
    Chrome is also affected (if you set 3rd-party cookies to be blocked)

Miscellaneous Information:
@ryanbr
Copy link
Author

ryanbr commented Jun 10, 2019 •
edited
Loading

Wasn't sure to submit issue with Chrome or here, or both. I just submitted here for the moment.

@bsclifton bsclifton added webcompat/shields Shields is breaking a website. feature/shields/cookies Cookie controls implemented as part of Shields. labels Jun 10, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jun 21, 2019
@ryanbr
Copy link
Author

ryanbr commented Jun 25, 2019

More reports of 3rd-party cookie issues:
https://www.sfoutsidelands.com/lineup/
https://community.brave.com/t/vimeo-cookies-sorry-because-of-its-privacy-settings-this-video-cannot-be-played-here/61505

@ryanbr ryanbr changed the title Blocking 3rd party cookies acts differently between Firefox and Brave 3rd-party cookie blocking causing website faults Jun 25, 2019
@ryanbr
Copy link
Author

ryanbr commented Jun 26, 2019

Related to the cookie issues: #4285

@ryanbr ryanbr mentioned this issue Jun 26, 2019
Open
ryanbr added a commit to ryanbr/referrer-whitelist that referenced this issue Jun 28, 2019
@ryanbr
Fix for vimeo playback issues brave/brave-browser#4770
a7e6b4f
pilgrim-brave added a commit to brave/referrer-whitelist that referenced this issue Jul 8, 2019
@pilgrim-brave
Merge pull request #3 from ryanbr/vimeofix
fad6129 
Fix for vimeo playback issues brave/brave-browser#4770
@ryanbr
Copy link
Author

ryanbr commented Jul 13, 2019

Should be fixed now. closing report

@ryanbr ryanbr closed this as completed Jul 13, 2019
@evelant
Copy link

evelant commented Mar 30, 2020

This is not fixed. Sites still fail with 3rd party cookies blocked. Specifically https://app.tactiq.io/ works fine in other browsers but fails on Brave with 3rd party cookies blocked.

@bsclifton
Copy link
Member

bsclifton commented Mar 30, 2020 •
edited
Loading

Thanks for raising, @AndrewMorsillo - I confirmed this is either a regression or is still a problem

The original steps of testing https://twitter.com/johnnyryan/status/1137967756148649984 and trying to navigate from the preview don't work on Brave but works on Chrome

@bsclifton bsclifton reopened this Mar 30, 2020
@pes10k
Copy link
Contributor

pes10k commented Aug 25, 2020

#8514 will be the solution to this. I'm going to close this issue, but since the issues are linked, we can verify that this is no longer a problem after #8514 lands.

Thanks for the report!

@pes10k pes10k closed this as completed Aug 25, 2020
@pes10k pes10k added the closed/duplicate Issue has already been reported label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported feature/shields/cookies Cookie controls implemented as part of Shields. priority/P4 Planned work. We expect to get to it "soon". webcompat/shields Shields is breaking a website.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pes10k @evelant @ryanbr @bsclifton @rebron