Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Closing all tabs doesn't close Brave when setting is enabled #9044

Closed
srirambv opened this issue Apr 6, 2020 · 2 comments · Fixed by brave/brave-core#5164
Closed

[Android] Closing all tabs doesn't close Brave when setting is enabled #9044

srirambv opened this issue Apr 6, 2020 · 2 comments · Fixed by brave/brave-core#5164
Assignees
@samartnik
Labels
bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes regression release-notes/include
Milestone
Android 1.5.x Hot...

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 6, 2020

Description

Closing all tabs doesn't close Brave

Steps to reproduce

  1. Enable Closing all tabs closes Brave from settings
  2. Close all open tabs
  3. Browser doesn't quit

Actual result

Closing all tabs doesn't close Brave when setting is enabled

Expected result

Closing all tabs should close Brave when setting is enabled

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? Yes
  • Beta build? Yes

Device details

  • Install type (ARM, x86): All
  • Device (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.5.120

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@srirambv srirambv added bug QA/Yes release-notes/include regression OS/Android Fixes related to Android browser functionality labels Apr 6, 2020
@srirambv srirambv added this to the Android 1.7.x Release milestone Apr 6, 2020
@LaurenWags
Copy link
Member

Doesn't reproduce on my x86 device - Asus Zenfone 1.5.120

@samartnik samartnik self-assigned this Apr 6, 2020
@samartnik samartnik mentioned this issue Apr 6, 2020
Merged
32 tasks
@kjozwiak kjozwiak mentioned this issue Apr 7, 2020
Closed
This was referenced Apr 8, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Apr 8, 2020 •
edited by btlechowski
Loading

Verification passed on OnePlus 6T with Android 10 running 1.5.131 x64 stable build

  • Verified closing all tabs don't close browser when the setting is disabled
  • Verified closing all tabs closes browser when the setting is enabled
  • Verified closing all normal tabs with a private tab open doesn't close the browser
  • Verified closing all private tabs with a normal tab open doesn't close the browser

Verification passed on Samsung Galaxy J3 version running BraveModernarm 1.5.131

  • Verified closing all tabs don't close browser when the setting is disabled
  • Verified closing all tabs closes browser when the setting is enabled
  • Verified closing all normal tabs with a private tab open doesn't close the browser
  • Verified closing all private tabs with a normal tab open doesn't close the browser

Verification passed on Samsung Tab A with Android 9 running 1.5.131 x64 stable build

  • Verified closing all tabs don't close browser when the setting is disabled
  • Verified closing all tabs closes browser when the setting is enabled
  • Verified closing all normal tabs with a private tab open doesn't close the browser
  • Verified closing all private tabs with a normal tab open doesn't close the browser

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.5.131 BraveModernx86.apk

  • Verified closing all tabs don't close browser when the setting is disabled
  • Verified closing all tabs closes browser when the setting is enabled
  • Verified closing all normal tabs with a private tab open doesn't close the browser
  • Verified closing all private tabs with a normal tab open doesn't close the browser

Verification passed on BraveModernarm v1.5.131 on Samsung Galaxy Tab S5e (Android 9.0)

  • Verified closing all tabs don't close browser when the setting is disabled
  • Verified closing all tabs closes browser when the setting is enabled
  • Verified closing all normal tabs with a private tab open doesn't close the browser
  • Verified closing all private tabs with a normal tab open doesn't close the browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes regression release-notes/include
Projects
None yet
Milestone
Android 1.5.x Hotfix 2 Release
Development

Successfully merging a pull request may close this issue.

Changed closing app on closing all tabs behavior to match android tabs brave/brave-core
3 participants
@srirambv @LaurenWags @samartnik