Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed closing app on closing all tabs behavior to match android tabs #5164

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Apr 6, 2020

Resolves brave/brave-browser#9044

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 6, 2020
@samartnik samartnik added this to the 1.9.x - Nightly milestone Apr 6, 2020
@samartnik samartnik self-assigned this Apr 6, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

kjozwiak commented Apr 7, 2020

Verification PASSED with Samsung Galaxy Tablet A on Android 9 using https://github.com/brave/brave-browser/releases/tag/v1.9.7.

Brave-Nightly 1.9.7 CR: 81.0.4044.83
  • ensured that Closing all tabs closes Brave is disabled by default on new profiles
  • ensured that Brave didn't close when Closing all tabs closes Brave is disabled
  • ensured once Closing all tabs closes Brave was enabled, closing the last tab closed Brave
    • ensured that using Close all tabs also closed Brave without any issues
  • ensured that close all PB tabs switched back to normal mode and didn't close Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Closing all tabs doesn't close Brave when setting is enabled
3 participants