Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 95 to Chromium 96 #18133

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Upgrade from Chromium 95 to Chromium 96 #18133

merged 7 commits into from
Nov 3, 2021

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Sep 15, 2021 •
edited
Loading

Fixes #18131
Related PR: brave/brave-core#10100

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Sep 15, 2021
@mkarolin mkarolin mentioned this pull request Sep 15, 2021
Merged
24 tasks
@mariospr mariospr force-pushed the cr96 branch 2 times, most recently from 330818f to a38438a Compare September 22, 2021 09:56
@mkarolin mkarolin force-pushed the cr96 branch 3 times, most recently from 0b9bc26 to a8dfc7c Compare October 6, 2021 05:41
@mariospr mariospr force-pushed the cr96 branch 3 times, most recently from afb27e6 to 846f68e Compare October 14, 2021 09:06
@mariospr mariospr force-pushed the cr96 branch 2 times, most recently from 4ff3d86 to 0ab4d3e Compare October 19, 2021 10:35
@mkarolin mkarolin force-pushed the cr96 branch 2 times, most recently from 0a0e575 to 4d7bcc6 Compare October 22, 2021 17:59
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 95 to Chromium 96 Upgrade from Chromium 95 to Chromium 96 Oct 22, 2021
samartnik
samartnik approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin mkarolin force-pushed the cr96 branch 2 times, most recently from b0e95f0 to a833e23 Compare November 1, 2021 18:26
@bsclifton bsclifton merged commit a4a4d38 into master Nov 3, 2021
@bsclifton bsclifton deleted the cr96 branch November 3, 2021 18:17
@mkarolin mkarolin added this to the 1.33.x - Nightly milestone Nov 3, 2021
mkarolin pushed a commit that referenced this pull request Nov 4, 2021
@bsclifton @mkarolin
Merge pull request #18133 from brave/cr96
589cc1b 
Upgrade from Chromium 95 to Chromium 96
@mkarolin mkarolin mentioned this pull request Nov 4, 2021
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samartnik samartnik samartnik approved these changes

@mariospr mariospr Awaiting requested review from mariospr

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 95 to Chromium 96
4 participants
@mkarolin @samartnik @bsclifton @mariospr