Skip to content

Commit

Permalink
Merge pull request #7731 from brave/doh-leak
Browse files Browse the repository at this point in the history
Specify resolver source to avoid using system resolver for CNAME adblocking
  • Loading branch information
darkdh authored and bbondy committed Feb 19, 2021
1 parent cd4e857 commit 17a1316
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions browser/net/brave_ad_block_tp_network_delegate_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ class AdblockCnameResolveHostClient : public network::mojom::ResolveHostClient {
network::mojom::ResolveHostParametersPtr optional_parameters =
network::mojom::ResolveHostParameters::New();
optional_parameters->include_canonical_name = true;
// Explicitly specify source to avoid using `HostResolverProc`
// which will be handled by system resolver
// See https://crbug.com/872665
optional_parameters->source = net::HostResolverSource::DNS;

network::mojom::NetworkContext* network_context =
content::BrowserContext::GetDefaultStoragePartition(context)
Expand Down

0 comments on commit 17a1316

Please sign in to comment.