Skip to content

Commit

Permalink
Fixed crash reporing is disabled by default on macOS for nightly/beta…
Browse files Browse the repository at this point in the history
… channel

fix brave/brave-browser#18315

When first-run dialog is closed, crash reporting pref is set based
on FirstRunDialogViewController::isStatsReportingEnabled.
So far, it returns always false.
It should return the value of GetDefaultPrefValueForMetricsReporting().
  • Loading branch information
simonhong committed Sep 27, 2021
1 parent c838547 commit 30e5c9b
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "base/i18n/rtl.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#include "brave/browser/metrics/metrics_reporting_util.h"
#include "brave/grit/brave_generated_resources.h"
#include "chrome/browser/ui/cocoa/key_equivalent_constants.h"
#include "chrome/grit/chromium_strings.h"
Expand Down Expand Up @@ -194,8 +195,8 @@ - (NSString*)windowTitle {
}

- (BOOL)isStatsReportingEnabled {
// This dialog doesn't have stats reporting checkbox.
return false;
// Give default value because we don't provide checkbox for this option.
return GetDefaultPrefValueForMetricsReporting();
}

- (BOOL)isMakeDefaultBrowserEnabled {
Expand Down

0 comments on commit 30e5c9b

Please sign in to comment.