Skip to content

Commit

Permalink
Rename Brave Together => Brave Talk (on NTP)
Browse files Browse the repository at this point in the history
Updates widget itself, settings screen (under customize), and a few
comments in the code

Fixes brave/brave-browser#16798
  • Loading branch information
bsclifton committed Jul 26, 2021
1 parent 54fdc6f commit 7e00ae0
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 11 deletions.
1 change: 0 additions & 1 deletion browser/ui/webui/brave_webui_source.cc
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ void CustomizeWebUIHTMLSource(const std::string &name,
{ "showFavoritesMenuLabel", IDS_BRAVE_NEW_TAB_SHOW_FAVORITES_MENU_LABEL }, // NOLINT
{ "showRewards", IDS_BRAVE_NEW_TAB_SHOW_REWARDS },
{ "showBinance", IDS_BRAVE_NEW_TAB_SHOW_BINANCE },
{ "showTogether", IDS_BRAVE_NEW_TAB_SHOW_TOGETHER },
{ "cards", IDS_BRAVE_NEW_TAB_SHOW_CARDS },
{ "brandedWallpaperOptIn", IDS_BRAVE_NEW_TAB_BRANDED_WALLPAPER_OPT_IN },
{ "topSitesTitle", IDS_BRAVE_NEW_TAB_TOP_SITES },
Expand Down
4 changes: 2 additions & 2 deletions common/extensions/api/brave_together.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[
{
"namespace": "braveTogether",
"description": "Use the <code>chrome.braveTogether</code> API to to receive info pertaining to the Brave Together feature.",
"description": "Use the <code>chrome.braveTogether</code> API to to receive info pertaining to the Brave Talk feature.",
"compiler_options": {
"implemented_in": "brave/browser/extensions/api/brave_together_api.h"
},
Expand All @@ -15,7 +15,7 @@
{
"name": "isSupported",
"type": "function",
"description": "Fetches whether or not Brave Together is supported",
"description": "Fetches whether or not Brave Talk is supported",
"parameters": [
{
"type": "function",
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
ToggleCardsSwitch,
ToggleCardsText
} from '../../../components/default'
import togetherBanner from './assets/bravetogether.png'
import togetherBanner from './assets/brave-talk.png'
import binanceBanner from './assets/binance.png'
import rewardsBanner from './assets/braverewards.png'
import geminiBanner from './assets/gemini.png'
Expand Down
2 changes: 1 addition & 1 deletion components/brave_together/browser/regions.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace brave_together {

// Brave Together is supported for all :)
// Brave Talk is supported for all :)
const std::vector<std::string> unsupported_regions = {
};

Expand Down
11 changes: 5 additions & 6 deletions components/resources/brave_components_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@

<message name="IDS_BRAVE_NEW_TAB_SHOW_REWARDS" desc="Text for settings show rewards option">Show Brave Rewards</message>
<message name="IDS_BRAVE_NEW_TAB_SHOW_BINANCE" desc="Text for show binance option">Show Binance</message>
<message name="IDS_BRAVE_NEW_TAB_SHOW_TOGETHER" desc="Text for show together option">Brave Together</message>
<message name="IDS_BRAVE_NEW_TAB_SHOW_CARDS" desc="Text for cards option">Cards</message>
<message name="IDS_BRAVE_NEW_TAB_BRANDED_WALLPAPER_OPT_IN" desc="Text for setting to opt-in to Branded Wallpapers on New Tab Page">Show Sponsored Images</message>
<message name="IDS_BRAVE_NEW_TAB_TOP_SITES" desc="Top Sites title">top sites</message>
Expand All @@ -233,13 +232,13 @@
Back
</message>

<message name="IDS_BRAVE_TOGETHER_PROMPT_TITLE" desc="Title for prompt about Brave Together">
<message name="IDS_BRAVE_TOGETHER_PROMPT_TITLE" desc="Title for prompt about Brave Talk">
You can start a private call in Brave.
</message>
<message name="IDS_BRAVE_TOGETHER_PROMPT_DESCRIPTION" desc="Description for prompt about Brave Together">
<message name="IDS_BRAVE_TOGETHER_PROMPT_DESCRIPTION" desc="Description for prompt about Brave Talk">
Start unlimited calls with friends and colleagues in Brave Talk.
</message>
<message name="IDS_BRAVE_TOGETHER_PROMPT_ACTION" desc="Button text for prompt about Brave Together">
<message name="IDS_BRAVE_TOGETHER_PROMPT_ACTION" desc="Button text for prompt about Brave Talk">
Try it out
</message>

Expand Down Expand Up @@ -303,7 +302,7 @@
<message name="IDS_BRAVE_NEW_TAB_CARDS_DESC" desc="Toggle cards description">By turning off Cards, all cards currently visible will be hidden. However, you may still be notified of new cards.</message>

<if expr="enable_sidebar">
<message name="IDS_SIDEBAR_BRAVE_TALK_ITEM_TITLE" desc="Title for brave together item in sidebar">
<message name="IDS_SIDEBAR_BRAVE_TALK_ITEM_TITLE" desc="Title for Brave Talk item in sidebar">
Brave Talk
</message>
<message name="IDS_SIDEBAR_WALLET_ITEM_TITLE" desc="Title for crypto wallet item in sidebar">
Expand Down Expand Up @@ -1015,7 +1014,7 @@
<message name="IDS_EDIT_CARDS_TITLE" desc="">Edit Cards</message>
<message name="IDS_REWARDS_WIDGET_TOS_AND_PP" desc="">By clicking [[title]], you agree to the <ph name="BEGIN_LINK1">$1</ph>Terms of Service<ph name="END_LINK1">$2</ph> and <ph name="BEGIN_LINK2">$3</ph>Privacy Policy<ph name="END_LINK2">$4</ph>.</message>
<message name="IDS_REWARDS_WIDGET_START_USING" desc="">Start using Brave Rewards</message>
<message name="IDS_TOGETHER_WIDGET_TITLE" desc="">Brave Together</message>
<message name="IDS_TOGETHER_WIDGET_TITLE" desc="">Brave Talk</message>
<message name="IDS_TOGETHER_WIDGET_WELCOME_TITLE" desc="">Start a private video call with your friends and colleagues.</message>
<message name="IDS_TOGETHER_WIDGET_START_BUTTON" desc="">Start video call</message>
<message name="IDS_TOGETHER_WIDGET_ABOUT_DATA" desc="">About your data</message>
Expand Down

0 comments on commit 7e00ae0

Please sign in to comment.