Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sparkle's relaunch api for update recommend dialog #1046

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 8, 2018

User can relaunch via update recommend dialog.
Fix brave/brave-browser#2477

screen shot 2018-12-08 at 7 53 15 pm

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Modify version in source tree to lower than released stable version for update test
    Ex, change 55.1 in package.json and chrome/VERSION.
  2. Build master release mode
  3. Start browser with update enabled mode and upgrade simulation mode to get update recommend dialog
    src/out/Release/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --simulate-upgrade
  4. Open help page and waiting to finish update and make dialog visible from app menu
  5. Click relaunch button
  6. Check relaunch is done

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

User can relaunch via update recommend dialog.
@simonhong simonhong self-assigned this Dec 8, 2018
@simonhong simonhong requested a review from darkdh December 8, 2018 11:45
@simonhong simonhong merged commit b166f67 into master Dec 11, 2018
@simonhong simonhong deleted the update_recommend_dialog_mac branch December 11, 2018 19:19
@simonhong
Copy link
Member Author

@rebron @kjozwiak @srirambv How about uplifting this fix?
This also fixes that #1041 did.

@simonhong
Copy link
Member Author

simonhong commented Dec 11, 2018

master(b166f67)
0.58.x(1616544)
0.59.x(42933cf)

@kjozwiak
Copy link
Member

kjozwiak commented Dec 12, 2018

@simonhong uplift request to 0.58.x approved after deliberating with @srirambv & @rebron 👍Typically, you should merge the PR into master & dev before requesting beta approval.

Please add/remove all needed labels and ensure that the associated issue is in the correct milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make update recommend dialog use sparkle's relaunch api
4 participants