Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API to set nonce and add ability to reset nonce information #11721

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Add API to set nonce and add ability to reset nonce information #11721

merged 2 commits into from
Jan 3, 2022

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 1, 2022

  • Adds an API for setting a custom nonce on a transaction
  • Adds a way to reset transactions and nonce info. Note that I acknowledge it would be more useful to do it per network, but for now it is only clearing everything. We can do per network later possibly based on demand.

Resolves brave/brave-browser#19760
Resolves brave/brave-browser#20286

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

bbondy added 2 commits January 1, 2022 16:22
@bbondy
Allow setting unapproved transaction nonce
3457049
@bbondy
Add ability to reset transaction info separately
ecc008e 
This is useful for local servers especially like Ganache when it is reset

Note that I acknowledge that it would be nicer to be able to clear per
network, but that can be done in a future task based on demand.
@bbondy bbondy requested a review from spylogsster January 1, 2022 22:25
@bbondy bbondy requested review from a team as code owners January 1, 2022 22:25
@bbondy bbondy self-assigned this Jan 1, 2022
@bbondy bbondy changed the title Nonce stuff Add API to set nonce and add ability to reset nonce information Jan 2, 2022
@bbondy bbondy merged commit 2dfec9d into master Jan 3, 2022
@bbondy bbondy deleted the nonce-stuff branch January 3, 2022 18:17
@bbondy bbondy added this to the 1.36.x - Nightly milestone Jan 3, 2022
@srirambv srirambv mentioned this pull request Feb 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spylogsster spylogsster spylogsster approved these changes

@darkdh darkdh darkdh approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging this pull request may close these issues.

Add mojom API for setting ETH transaction nonce Add a way to reset local transaction / nonce information
3 participants
@bbondy @spylogsster @darkdh