Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images data source to wallet page and panel #11966

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jan 24, 2022

Resolves brave/brave-browser#20650

Icons can be added this way:

<img src="chrome://image?https://brave.com/static-assets/images/brave-favicon.png"></img>
// The sanitized image source provides a convenient mean to embed images into
// WebUIs. For security reasons WebUIs are not allowed to download and decode
// external images in their renderer process. The sanitized image source allows
// external images in WebUIs by downloading the image in the browser process,
// decoding the image in an isolated utility process, re-encoding the image as
// PNG and sending the now sanitized image back to the requesting WebUI. You can
// reach the image source via:
//
//   chrome://image?<external image URL>

image

More details:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/sanitized_image_source.h;l=37?q=SanitizedImageSource&ss=chromium

Used in Chrome NTP page https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/new_tab_page/new_tab_page_ui.cc;l=390?q=SanitizedImageSource%20&ss=chromium

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • No manual tests required

Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but let's ask @fmarier / @diracdeltas to be sure.

@bbondy bbondy requested review from diracdeltas and fmarier January 24, 2022 13:46
@spylogsster spylogsster merged commit d94ab7f into master Jan 24, 2022
@spylogsster spylogsster deleted the issue-20650 branch January 24, 2022 19:43
@spylogsster spylogsster added this to the 1.36.x - Nightly milestone Jan 24, 2022
@simonhong simonhong mentioned this pull request Mar 10, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to show chain icons for wallet pages
2 participants