[extensions] Add a switch to generate a publisher proof #12090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atuchin-m
force-pushed
the
add-switch-to-generate-publisher-proof
branch
2 times, most recently
from
0e5c058 to
52be4d9
Compare
atuchin-m
force-pushed
the
add-switch-to-generate-publisher-proof
branch
from
52be4d9 to
f2d5b58
Compare
goodov
reviewed
Feb 2, 2022
goodov
reviewed
Feb 3, 2022
| publisher_key = \ | ||
| ReadInputKey(cmd->GetSwitchValuePath(kPublisherKeySwitch)); \ | ||
| if (!publisher_key) \ | ||
| return false; \ |
There was a problem hiding this comment.
need to state the fact that error_message_ will be set by ReadInputKey in this case.
| #include "base/command_line.h" | ||
| #include "base/files/file_path.h" | ||
| #include "components/crx_file/crx_creator.h" | ||
| #include "components/crx_file/id_util.h" |
| result = crx_file::CreateWithPublisherKey(output_path, zip_path, \ | ||
| signing_key, publisher_key.get()); | ||
|
|
||
| #include "src/extensions/browser/extension_creator.cc" |
|
|
||
| // Generate a publish key hash from .pem file in the format used in | ||
| // crx_verifier.cc. | ||
| std::vector<uint8_t> GetPublicKeyHash(const base::FilePath& pem_path) { |
There was a problem hiding this comment.
put it into fixture or anonymous namespace.
| base::FilePath CreateTestCrx() { | ||
| base::ScopedAllowBlockingForTesting allow_blocking; | ||
|
|
||
| brave::RegisterPathProvider(); |
goodov
reviewed
Feb 4, 2022
| publisher_key = \ | ||
| ReadInputKey(cmd->GetSwitchValuePath(kPublisherKeySwitch)); \ | ||
| if (!publisher_key) \ | ||
| return false; /* error_message_ was be set by ReadInputKey() */ \ |
goodov
approved these changes
Feb 4, 2022
iefremov
approved these changes
Feb 4, 2022
fmarier
approved these changes
Feb 9, 2022
| namespace extensions { | ||
|
|
||
| namespace { | ||
| // Generate a publish key hash from .pem file in the format used in |
There was a problem hiding this comment.
By publish key, do you mean a publisher key or a public key?
There was a problem hiding this comment.
I mean a public key here: the function can fetch a public key and generate it's hash from any PEM file (not only is used for a publisher proof)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#873
This PR adds ability to add a publisher proof during packing an extension or components. This will be used on CI during signing brave components.
How to use it :
brave.exe --pack-extension=.\test-extension --pack-extension-key=.\key.pem --brave-extension-publisher-key=.\publisher.pemReturn zero if all is good.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: