Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window.ethereum object when reloading pages #12193

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 9, 2022

Resolves brave/brave-browser#20993

reload.mp4

Renew render configuration parameters when render creates a script context and create js handler if it was not created before.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Set Wallet type preference to None
  2. Open chainlist.org in a new tab
  3. Set Wallet type preference to Brave Wallet
  4. Go to tab with chainlist.org and reload it
  5. check window.ethereum object in console

@spylogsster spylogsster changed the title Create wallet ethereum js handler if it doesnt exist Add window.ethereum object when reloading pages Feb 9, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster spylogsster merged commit 23d46d9 into master Feb 9, 2022
@spylogsster spylogsster deleted the issue-20993 branch February 9, 2022 18:47
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 9, 2022
@spylogsster spylogsster restored the issue-20993 branch February 10, 2022 19:26
brave-builds pushed a commit that referenced this pull request Feb 10, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.37.42 Chromium: 98.0.4758.87 (Official Build) nightly (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Windows 11 Version Dev (Build 22543.1000)
  • Verified steps from PR description
12193.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window.ethereum is not available after reloading page for default wallet setting changes
3 participants