-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promo notification bitflyer #12268
Promo notification bitflyer #12268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
@kjozwiak CI fails for the lint error which is not related to PR changes. [2022-02-15T16:54:38.313Z] browser/brave_vpn/sources.gni [2022-02-15T16:54:38.313Z] This change has GN build file diff for browser/brave_vpn/sources.gni [2022-02-15T16:54:38.313Z] browser/sources.gni [2022-02-15T16:54:38.313Z] This change has GN build file diff for browser/sources.gni [2022-02-15T16:54:38.313Z] components/skus/browser/BUILD.gn [2022-02-15T16:54:38.313Z] This change has GN build file diff for components/skus/browser/BUILD.gn [2022-02-15T16:54:38.313Z] components/skus/browser/rs/cxx/BUILD.gn [2022-02-15T16:54:38.313Z] This change has GN build file diff for components/skus/browser/rs/cxx/BUILD.gn [2022-02-15T16:54:38.313Z] ios/browser/BUILD.gn [2022-02-15T16:54:38.313Z] This change has GN build file diff for ios/browser/BUILD.gn [2022-02-15T16:54:38.313Z] [2022-02-15T16:54:38.313Z] Format errors detected. Run npm format locally to fix. |
yup 👍 known issues on |
Verification PASSED on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 1.35.x
approved after deliberating with @brave/uplift-approvers. QA has verified the PR on 1.35.x
using a one off build as per #12268 (comment). The remaining checks will be completed via the RC as per brave/brave-browser#20725 (comment).
Resolves brave/brave-browser#20725
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: