Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promo notification bitflyer #12268

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Promo notification bitflyer #12268

merged 6 commits into from
Feb 16, 2022

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#20725

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 15, 2022
@deeppandya deeppandya added this to the 1.35.x - Release #3 milestone Feb 15, 2022
@deeppandya deeppandya requested review from SergeyZhukovsky and a team February 15, 2022 16:26
@deeppandya deeppandya self-assigned this Feb 15, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya
Copy link
Contributor Author

@kjozwiak CI fails for the lint error which is not related to PR changes.

[2022-02-15T16:54:38.313Z] browser/brave_vpn/sources.gni

[2022-02-15T16:54:38.313Z] This change has GN build file diff for browser/brave_vpn/sources.gni

[2022-02-15T16:54:38.313Z] browser/sources.gni

[2022-02-15T16:54:38.313Z] This change has GN build file diff for browser/sources.gni

[2022-02-15T16:54:38.313Z] components/skus/browser/BUILD.gn

[2022-02-15T16:54:38.313Z] This change has GN build file diff for components/skus/browser/BUILD.gn

[2022-02-15T16:54:38.313Z] components/skus/browser/rs/cxx/BUILD.gn

[2022-02-15T16:54:38.313Z] This change has GN build file diff for components/skus/browser/rs/cxx/BUILD.gn

[2022-02-15T16:54:38.313Z] ios/browser/BUILD.gn

[2022-02-15T16:54:38.313Z] This change has GN build file diff for ios/browser/BUILD.gn

[2022-02-15T16:54:38.313Z]

[2022-02-15T16:54:38.313Z] Format errors detected. Run npm format locally to fix.

@kjozwiak
Copy link
Member

@kjozwiak CI fails for the lint error which is not related to PR changes.

[2022-02-15T16:54:38.313Z] browser/brave_vpn/sources.gni

[2022-02-15T16:54:38.313Z] This change has GN build file diff for browser/brave_vpn/sources.gni

[2022-02-15T16:54:38.313Z] browser/sources.gni

[2022-02-15T16:54:38.313Z] This change has GN build file diff for browser/sources.gni

[2022-02-15T16:54:38.313Z] components/skus/browser/BUILD.gn

[2022-02-15T16:54:38.313Z] This change has GN build file diff for components/skus/browser/BUILD.gn

[2022-02-15T16:54:38.313Z] components/skus/browser/rs/cxx/BUILD.gn

[2022-02-15T16:54:38.313Z] This change has GN build file diff for components/skus/browser/rs/cxx/BUILD.gn

[2022-02-15T16:54:38.313Z] ios/browser/BUILD.gn

[2022-02-15T16:54:38.313Z] This change has GN build file diff for ios/browser/BUILD.gn

[2022-02-15T16:54:38.313Z]

[2022-02-15T16:54:38.313Z] Format errors detected. Run npm format locally to fix.

yup 👍 known issues on 1.35.x.

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Andorid 12 using the 1.35.100 Nightly build that @deeppandya provided due to this going directly into 1.35.x and skipping both 1.37.x & 1.36x..

Clean Install - Japan

  • ensured that the BitFlyer notification only appears after 120min as per [Android] bitFlyer announcement notification for Japan users brave-browser#20725 (comment)
    • moved the time ~15min ahead and ensured that the notification isn't being displayed
    • moved the time ~1h ahead and ensured that the notification isn't being displayed
    • moved the time ~1.5hrs ahead and ensured that the notification isn't being displayed
  • ensured that the BitFlyer notification is being displayed after 120min (2hrs)
  • ensured that tapping on the notification opens https://try.bravesoftware.jp/brave_20220121-1
  • ensured that the BitFlyer doesn't appear again once it's been displayed once
    • moved the time a few hours ahead and ensured that the BitFlyer notification doesn't re-appear
    • moved the date/time several times and ensured that the BitFlyer notification doesn't re-appear
Example Example Example
image image image

Clean Install - USA/Canada

  • ensured that the BitFlyer notification doesn't appear after launching Brave for the first time
    • moved the time ~15min ahead and ensured that the notification isn't being displayed
    • moved the time ~2hrs ahead and ensured that the notification isn't being displayed
    • moved the time ~4hrs ahead and ensured that the notification isn't being displayed
    • moved the date/time a head a few times (1, 2, 3 days) and ensured that the notification isn't being displayed

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.35.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on 1.35.x using a one off build as per #12268 (comment). The remaining checks will be completed via the RC as per brave/brave-browser#20725 (comment).

@kjozwiak kjozwiak merged commit c13cc9a into 1.35.x Feb 16, 2022
@kjozwiak kjozwiak deleted the promo_notification_bitflyer branch February 16, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants