Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isBraveWallet property to window.ethereum #12794

Merged

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Mar 28, 2022

Resolves brave/brave-browser#21949

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Navigate to a webpage (brave.com)
  2. Open the developer console
  3. Type in: window.ethereum.isBraveWallet
  4. expect true

@josheleonard josheleonard requested a review from a team as a code owner March 28, 2022 23:00
@josheleonard josheleonard self-assigned this Mar 28, 2022
@josheleonard josheleonard requested a review from bbondy March 28, 2022 23:04
@josheleonard josheleonard force-pushed the feature-add-isBrave-property-to-window-dot-ethereum branch from 3d2b421 to 0928092 Compare March 29, 2022 05:03
@josheleonard josheleonard force-pushed the feature-add-isBrave-property-to-window-dot-ethereum branch from 0928092 to 65a4914 Compare March 29, 2022 16:14
@josheleonard josheleonard changed the title feat: add isBrave property to window.ethereum feat: add isBraveBrowser property to window.ethereum Mar 29, 2022
@josheleonard josheleonard changed the title feat: add isBraveBrowser property to window.ethereum feat: add isBraveWallet property to window.ethereum Mar 29, 2022
@josheleonard josheleonard force-pushed the feature-add-isBrave-property-to-window-dot-ethereum branch from 65a4914 to 3c98536 Compare March 29, 2022 16:45
@josheleonard josheleonard added this to the 1.39.x - Nightly milestone Mar 29, 2022
@josheleonard josheleonard merged commit 2a93be1 into master Mar 29, 2022
@josheleonard josheleonard deleted the feature-add-isBrave-property-to-window-dot-ethereum branch March 29, 2022 18:42
josheleonard added a commit that referenced this pull request Mar 29, 2022
…window-dot-ethereum

feat: add `isBraveWallet` property to `window.ethereum`
@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2022

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.39.32 Chromium: 100.0.4896.79 (Official Build) nightly (64-bit)
-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | Windows 11 Version 21H2 (Build 22000.593)

Went through the STR/Cases outlined via #12794 (comment).

1.37.109 Chromium: 100.0.4896.60 (Broken) 1.39.32 Chromium: 100.0.4896.79 (Fixed)
releaseBuild nightlyBuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isBraveWallet property to window.ethereum
3 participants