Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix News scroll issue #12865

Merged
merged 7 commits into from
Apr 14, 2022
Merged

Conversation

tapanmodh
Copy link
Contributor

@tapanmodh tapanmodh commented Apr 1, 2022

Resolves brave/brave-browser#21475

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 1, 2022
@tapanmodh tapanmodh added this to the 1.38.x - Beta milestone Apr 1, 2022
@tapanmodh tapanmodh marked this pull request as draft April 7, 2022 18:08
@tapanmodh tapanmodh added the CI/skip-android Do not run CI builds for Android label Apr 7, 2022
@tapanmodh tapanmodh removed the CI/skip-android Do not run CI builds for Android label Apr 13, 2022
@tapanmodh tapanmodh marked this pull request as ready for review April 13, 2022 08:42
@github-actions github-actions bot added rebase and removed rebase labels Apr 13, 2022
Copy link
Contributor

@alexsafe alexsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tapanmodh we can probably get rid of the ScrollView import too. and replace it in calls like mParentScrollView.fullScroll(ScrollView.FOCUS_UP); i think those are the only references left

@deeppandya deeppandya merged commit 351840f into master Apr 14, 2022
@deeppandya deeppandya deleted the news_scroll_issue_fix_android branch April 14, 2022 06:20
brave-builds pushed a commit that referenced this pull request Apr 14, 2022
deeppandya pushed a commit that referenced this pull request Apr 19, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 12 using the following build(s):

1.39.73 Chromium: 101.0.4951.34

Created brave/brave-browser#22434 as a follow up. The scrolling has definitely improved but we're still running into one case where the velocity of the scroll basically stops when it hits a certain area of the feed. This usually happens at the start of the feed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave News - "velocity" (when scrolling up) stops when top is reached
5 participants