-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix News scroll issue #12865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tapanmodh we can probably get rid of the ScrollView import too. and replace it in calls like mParentScrollView.fullScroll(ScrollView.FOCUS_UP);
i think those are the only references left
Verification PASSED on
Created brave/brave-browser#22434 as a follow up. The scrolling has definitely improved but we're still running into one case where the velocity of the scroll basically stops when it hits a certain area of the feed. This usually happens at the start of the feed. |
Resolves brave/brave-browser#21475
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: