Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force hide cosmetic filters from regional lists in Standard Shields mode #12917

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#22032

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Check the sites mentioned in the associated issue - there should be no cookie notices shown when visiting in Standard Shields blocking mode and with the Easylist-Cookie List - Filter Obtrusive Cookie Notices entry active in brave://adblock (both of which should be true by default).

Copy link
Collaborator

@ryanbr ryanbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, was surprised this wasn't default for regional lists

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@antonok-edm antonok-edm merged commit a098c0b into master Apr 7, 2022
@antonok-edm antonok-edm deleted the force-hide-regional-cosmetic-filters branch April 7, 2022 17:18
brave-builds pushed a commit that referenced this pull request Apr 7, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Apr 7, 2022

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.39.40 Chromium: 100.0.4896.79 (Official Build) nightly (64-bit)
-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | Windows 11 Version 21H2 (Build 22000.593)

Verification PASSED on Pixel 6 running Android 12 using the following build(s)

Brave | 1.39.41 Chromium: 100.0.4896.79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unblocked cookie consent dialogs on some websites when the Cookie List is enabled
4 participants