Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fixed crash on sending tabs to another device #12920

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Apr 6, 2022

Resolves brave/brave-browser#22128

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 6, 2022
@samartnik samartnik added this to the 1.39.x - Nightly milestone Apr 6, 2022
@samartnik samartnik self-assigned this Apr 6, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

kjozwiak commented Apr 7, 2022

Reproduced the issue using 1.37.112 Chromium: 100.0.4896.79. Once Sync was enabled and Open Tab selected on both devices, selecting Send to your devices will instantly crash Brave.

Verification PASSED on Pixel 6 running Android 12 using 1.39.39 Chromium: 100.0.4896.79

Went through the STR/Cases outlined via brave/brave-browser#22128 (comment) and ensured that Brave doesn't crash when Send to your devices is being used.

Example Example Example
Screenshot_20220407-095829 Screenshot_20220407-095912 sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser crash when selecting 'Send to your devices'
3 participants