Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add Obj-C wrapper for URLPattern #12940

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Apr 7, 2022

Resolves brave/brave-browser#22160

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson requested review from cuba and Brandon-T April 7, 2022 19:12
@kylehickinson kylehickinson requested a review from a team as a code owner April 7, 2022 19:12
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 7, 2022
@kylehickinson kylehickinson self-assigned this Apr 7, 2022
@kylehickinson kylehickinson added this to the 1.39.x - Nightly milestone Apr 7, 2022
@kylehickinson kylehickinson force-pushed the ios-url-pattern-wrapper branch 2 times, most recently from ff5c12b to 4de5353 Compare April 7, 2022 19:36
@kylehickinson kylehickinson force-pushed the ios-url-pattern-wrapper branch from 4de5353 to 685688d Compare April 7, 2022 20:07
@kylehickinson kylehickinson merged commit 69f7c89 into master Apr 7, 2022
@kylehickinson kylehickinson deleted the ios-url-pattern-wrapper branch April 7, 2022 20:35
brave-builds pushed a commit that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Expose an Obj-C wrapper for URLPattern
3 participants