Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 100.0.4896.88 to Chromium 100.0.4896.127 (1.38.x) #13030

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Upgrade from Chromium 100.0.4896.88 to Chromium 100.0.4896.127 (1.38.x) #13030

merged 2 commits into from
Apr 15, 2022

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Apr 14, 2022

Resolves brave/brave-browser#22318

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) labels Apr 14, 2022
@emerick emerick added this to the 1.38.x - Beta milestone Apr 14, 2022
@emerick emerick requested review from a team as code owners April 14, 2022 22:29
@emerick emerick self-assigned this Apr 14, 2022
@emerick emerick requested a review from a team April 15, 2022 13:19
kjozwiak
kjozwiak approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍

@kjozwiak kjozwiak merged commit 8238b43 into 1.38.x Apr 15, 2022
@kjozwiak kjozwiak deleted the 100.0.4896.127_1.38.x branch April 15, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaiplesa mihaiplesa mihaiplesa approved these changes

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@emerick emerick

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@emerick @mihaiplesa @kjozwiak @brave-browser-releases