Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): implement DApps decrypt screen (uplift to 1.40.x) #13876

Closed

Conversation

Pavneet-Sing
Copy link

Uplift of #13868
Resolves brave/brave-browser#23260

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 21, 2022
@Pavneet-Sing Pavneet-Sing requested a review from a team June 21, 2022 08:33
@Pavneet-Sing Pavneet-Sing changed the title Uplift of #13868 (squashed) to release fix(wallet): implement DApps decrypt screen (uplift to 1.40.x) Jun 21, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 21, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jun 22, 2022

Closing as there's no 1.40.x maintenance release for this cycle so we'll basically only be doing chromium bumps and HF (hotfixes) if needed. With HF releases, we only include critical fixes rather than additions/new features. The above is a substantial change so we'll let it ride via 1.41.x.

@kjozwiak kjozwiak closed this Jun 22, 2022
@kjozwiak kjozwiak deleted the pr13868_implement-dapps-decrypt-screen_1.40.x branch June 22, 2022 19:57
@github-actions github-actions bot added this to the 1.40.x - Release #2 milestone Jun 22, 2022
@kjozwiak kjozwiak removed this from the 1.40.x - Release #2 milestone Jun 22, 2022
@kjozwiak kjozwiak removed CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 22, 2022
@kjozwiak kjozwiak removed the request for review from a team June 22, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants