Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experimental] Add Brave News subscribe button #14077

Merged
merged 53 commits into from
Aug 8, 2022
Merged

[Experimental] Add Brave News subscribe button #14077

merged 53 commits into from
Aug 8, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Jul 8, 2022 •
edited
Loading

Resolves brave/brave-browser#23778

Note: The UI for this feature hasn't been finalised (hence the Experimental), so it's currently behind the brave://flags/#brave-news-subscribe-button flag. I'd like to merge it as is, so we can iterate on the UI.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Jul 8, 2022
@fallaciousreasoning
Copy link
Contributor Author

Current UI is Below
One feed subscribed, one available

Pending subscription/unsubscription

Hide & don't show this again clicked

New setting, in customise Brave News

@fallaciousreasoning fallaciousreasoning marked this pull request as ready for review July 14, 2022 01:48
@fallaciousreasoning
Copy link
Contributor Author

fallaciousreasoning commented Jul 14, 2022 •
edited
Loading

Hey @petemill , as you can probably see the design of the drop down is a bit rough. I have a few questions:

  1. Should this be behind a flag?
  2. Do we need a UX person to tidy it up a bit?
  3. Currently, I only parse RSS Feeds from the page if the Chromium flag --enable-features=WebFeed is set. Should we implicitly set this and/or override it with our own flag.

@petemill
Copy link
Member

petemill commented Jul 18, 2022 •
edited by fallaciousreasoning
Loading

  • Should this be behind a flag?
  • Probably, until we get the UX finalized.
  • Do we need a UX person to tidy it up a bit?
  • Currently, I only parse RSS Feeds from the page if the Chromium flag --enable-features=WebFeed is set. Should we implicitly set this and/or override it with our own flag.
  • It would be great to have this work even when WebFeed is not enabled. That feature is a separate chrome-only feature, considering (I believe) it needs a server part which we don't have or intend to implement.

@fallaciousreasoning fallaciousreasoning requested review from a team as code owners July 19, 2022 00:24
@fallaciousreasoning fallaciousreasoning changed the title Add Brave News subscribe button [Experimental] Add Brave News subscribe button Jul 21, 2022
@fallaciousreasoning fallaciousreasoning force-pushed the bn-subscribe branch 2 times, most recently from 1e4007e to 9243ca6 Compare July 21, 2022 03:00
@fallaciousreasoning
Copy link
Contributor Author

@petemill & @simonhong could you PTAL for me?

simonhong
simonhong reviewed Jul 22, 2022
View reviewed changes
browser/about_flags.cc Outdated Show resolved Hide resolved
browser/brave_news/BUILD.gn Outdated Show resolved Hide resolved
browser/brave_news/brave_news_tab_helper.h Outdated Show resolved Hide resolved
browser/brave_news/brave_news_tab_helper.h Outdated Show resolved Hide resolved
browser/brave_news/brave_news_tab_helper.h Outdated Show resolved Hide resolved
browser/ui/views/brave_news/brave_news_bubble_view.h Show resolved Hide resolved
browser/ui/views/brave_news/brave_news_bubble_view.cc Outdated Show resolved Hide resolved
browser/ui/views/brave_news/brave_news_bubble_view.cc Outdated Show resolved Hide resolved
browser/ui/views/brave_news/brave_news_bubble_view.cc Show resolved Hide resolved
patches/chrome-renderer-chrome_content_renderer_client.cc.patch Outdated Show resolved Hide resolved
@fallaciousreasoning fallaciousreasoning force-pushed the bn-subscribe branch 3 times, most recently from a4ea388 to 24d41e4 Compare July 25, 2022 03:23
@fallaciousreasoning fallaciousreasoning force-pushed the bn-subscribe branch 2 times, most recently from 5f01992 to 8fc26a4 Compare July 25, 2022 23:42
simonhong
simonhong approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 👍🏼

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit d7a3ce5 into master Aug 8, 2022
@fallaciousreasoning fallaciousreasoning deleted the bn-subscribe branch August 8, 2022 02:06
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

@simonhong simonhong simonhong approved these changes

@petemill petemill Awaiting requested review from petemill

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@fallaciousreasoning fallaciousreasoning

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging this pull request may close these issues.

Brave News can suggest the current site to subscribe to
6 participants
@fallaciousreasoning @petemill @brave-builds @bridiver @goodov @simonhong